Combo popup size is not constrained to the screen

[Tazmondo]

Occurred after updating from 2.2 to 2.4, likely caused by ec4d167.

When the combo contains a lot of items, the combo size extends up and out of the screen. Since the size is not constrained, the AutomaticCanvasSize never kicks in and the canvas size never increased. This means you can't scroll to reach the off-screen elements.

My initial solution was to add a UISizeConstraint to the combo popup, however there is currently a bug that means this solution does not work.

I think that until this bug is fixed, it would be better to revert to the old behaviour.

[Tazmondo]

Also willing to make a PR for this, but wanted to hear your thoughts first.

[SirMallard]

Thanks for raising this and sorry for not responding earlier. I changed this behaviour to remove unecessary computation, at the cost of potential issues if the box was too high. It could be fixed by doing a delayed update on the box position after all the UI has loaded in, rather than counting contents. I would like to see what solution you come up.

[Tazmondo]

Sure, I'll work on a solution. I'm thinking https://create.roblox.com/docs/reference/engine/classes/UIListLayout#AbsoluteContentSize may be useful