Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-mount workspace on role change #9244

Open
mmmarcos opened this issue Dec 20, 2024 · 2 comments
Open

Re-mount workspace on role change #9244

mmmarcos opened this issue Dec 20, 2024 · 2 comments
Labels
A-Client Area: Parsec desktop application I-Rust Impact: Rust-related stuff

Comments

@mmmarcos
Copy link
Contributor

Related to #9229.

When the user's workspace role is updated, and the user is logged-in, the corresponding workspace mountpoint should be re-mounted in order to have the right flags: RW or RO. This is valid for both Linux and Windows.

Specifically, the re-mount is required on these role changes:

  • OWNER | MANAGER | CONTRIBUTOR ---> READER
    -READER ---> OWNER | MANAGER | CONTRIBUTOR

In principle, since the GUI receives an event on role changes, the re-mount could be implemented at GUI/app-level without chaning libparsec.

@Max-7
Copy link
Contributor

Max-7 commented Dec 23, 2024

Depends on #9252

There's currently no event exposed to the bindings to a workspace role update.

@FirelightFlagboy FirelightFlagboy added I-Rust Impact: Rust-related stuff A-Client Area: Parsec desktop application labels Jan 8, 2025
@mmmarcos
Copy link
Contributor Author

mmmarcos commented Jan 8, 2025

There can be open files in the workspace, potentially with non-saved changes, so the app should probably detect and/or ask the user before the remount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client Area: Parsec desktop application I-Rust Impact: Rust-related stuff
Projects
None yet
Development

No branches or pull requests

3 participants