Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in getNPIData.py #865

Open
2 tasks done
annawendler opened this issue Dec 11, 2023 · 0 comments · May be fixed by #891
Open
2 tasks done

Errors in getNPIData.py #865

annawendler opened this issue Dec 11, 2023 · 0 comments · May be fixed by #891
Assignees
@patricklnz
Labels
class::bug Bugs found in the software loc::data handling This issue concerns any kind of data handling.

Comments

@annawendler
Copy link
Member

annawendler commented Dec 11, 2023 •
edited
Loading

Bug description

  1. When using fine_resolution=0 the data frame df_npis_combinations_pre is not defined which leads to an error in line 263.
  2. In line 1425 we define array_exclusion_diag using a deepcopy of array exclusion. In line 1428 we want to write array_exclusion[i, i] = 0 and we get the error "assignment destination is read-only" when using fine_resolution=1.

Version

Linux

To reproduce

For the first bug: Run getNPIData with fine_resolution = 0.

For the second bug: Run getNPIData with fine_resolution = 1.

Relevant log output

No response

Add any relevant information, e.g. used compiler, screenshots.

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@annawendler annawendler added class::bug Bugs found in the software loc::data handling This issue concerns any kind of data handling. labels Dec 11, 2023
@patricklnz patricklnz self-assigned this Jan 8, 2024
@patricklnz patricklnz moved this from Product Backlog to 🏗 Development in MEmilio: Data science, tools and more Jan 8, 2024
@patricklnz patricklnz linked a pull request Jan 15, 2024 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patricklnz patricklnz

Labels
class::bug Bugs found in the software loc::data handling This issue concerns any kind of data handling.
Projects
MEmilio: Data science, tools and more
Status: 🏗 Development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

865 Resolve errors in getNPIData for fine resolution 0 and 1 SciCompMod/memilio
2 participants
@patricklnz @annawendler