Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SBBTabBar doesn't handle SafeArea #262

Open
2 tasks done
brosnic opened this issue Jan 10, 2025 · 1 comment
Open
2 tasks done

[Bug]: SBBTabBar doesn't handle SafeArea #262

brosnic opened this issue Jan 10, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@brosnic
Copy link
Contributor

brosnic commented Jan 10, 2025

Preflight Checklist

Bug type

Functionality

Which release are you using?

2.1.1

Flutter SDK version

3.27.1

Additional settings

iPhone 15

Expected

Correct Bottom-Spacing

What happened?

TabItem text behind black bar
Simulator Screenshot - iPhone 15 - 2025-01-10 at 14 15 05

Steps to reproduce the issue

  1. Move TabBar in Example App to bottom
  2. look at it
  3. fix it

Relevant log output

No response

@brosnic brosnic added the bug Something isn't working label Jan 10, 2025
@smallTrogdor smallTrogdor self-assigned this Jan 14, 2025
@smallTrogdor smallTrogdor moved this from Funnel to In Progress in Design System Mobile Jan 14, 2025
@smallTrogdor
Copy link
Contributor

When looking at the SBBTabBar, there is a refactoring needed in conjunction with #235 . The Layouting seems very strange after 5 min analysis. Will get to it next week.

As a workaround:
place a Column around it with a fixed height Container with the correct color below ....

Column(
            children: [
              SBBTabBar(
                items: items,
                showWarning: true,
                onTabChanged: (task) async {},
                controller: controller,
                warningSemantics: 'Warning',
                onTap: (tab) {
                  sbbToast.show(message: 'Tab tapped: Item ${tab.id}');
                },
              ),
              Container(width: double.infinity, height: sbbDefaultSpacing, color: SBBColors.white)
            ],
          )

@smallTrogdor smallTrogdor moved this from In Progress to Todo in Design System Mobile Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants