Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrap in braces instead of splitting command #26

Open
klieret opened this issue Oct 17, 2024 · 0 comments · May be fixed by #153
Open

wrap in braces instead of splitting command #26

klieret opened this issue Oct 17, 2024 · 0 comments · May be fixed by #153
Labels
refactor

Comments

@klieret
Copy link
Member

klieret commented Oct 17, 2024 •
edited
Loading

Doesn't seem to work with pexpect of PS1 variable.
erkinalp added a commit to erkinalp/SWE-ReX that referenced this issue Dec 20, 2024
@devin-ai-integration @erkinalp
Use braces for command wrapping instead of simple semicolon join
7ca33db 
When running multiple commands, wrap each command in braces to maintain
proper PS1 handling with pexpect. This prevents issues with PS1 variable
interactions while still allowing multiple commands to be executed.

Changes:
- Modify _run_normal to wrap commands in braces
- Maintain command isolation while preserving PS1 handling
- Keep existing bashlex parsing for command splitting

Fixes SWE-agent#26

Co-Authored-By: Erkin Alp Güney <[email protected]>
@erkinalp erkinalp linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use braces for command wrapping instead of simple semicolon join erkinalp/SWE-ReX
1 participant
@klieret