-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Fix Notebook Tester Action #87
Comments
Not sure if this workflow was ever running successfully ? |
Tried to have the ir kernel installed, but running into issues still - its not recognizing r too. |
Whilst looking into this further, I took a step back to check if the other notebooks could be verified ( besides the one which was failing which needed IR). I saw more failures for other kernels. Below is the list of all the different kernels needed in the various notebooks we have here so far: find tutorials/notebooks/* -name '*.ipynb' -exec grep -A 1 ' Thus do we need to make sure these are installed too?? Do we need to re-think/design this for handling all possible kernel types? |
As per discussion in the meeting: This workflow was created to validate the notebooks, as over time the required dependencies in them, may break them ( and have it unusable) @antNIH may have used a package/option with jupyter which we can try to see if it works better in validating. Otherwise, need to check if there is any way (option) to ignore the kernel checks. As per @zbyosufzai the kernels named/needed (ie python310-sdkv2, python38-azureml) are not 'necessarily' needed. There was a mention about updating the notebook code and removing references to these ( if we are sure they are not needed), but then there is concern, if the notebooks would still work the same if we remove it. |
Thanks @zbyosufzai for the pointer to nbmake package and this writeup - https://dev.to/semaphore/how-to-test-jupyter-notebooks-with-pytest-and-nbmake-fl3 https://github.com/treebeardtech/nbmake It looks promising : however below are my findings/issues so far -
The above execute's the notebook and all the 'source' code parts of it. The above fails due to file not found error.
I did not try running any more ( aassuming they too may have run time errors) . Next I tried to check only for import errors
This took a long time to run ( for all 10 notebooks) and came back with errors for 3 of them.
Are these known or do we need to fix them ? Is it ok to just check for import errors ? @kyleoconnell-NIH what do we exactly mean by 'dependency' issues ? |
Possible issue may be due to not finding jupyter kernel
https://github.com/STRIDES/NIHCloudLabAzure/blob/main/.github/workflows/check-jupyter.yml
The text was updated successfully, but these errors were encountered: