Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review file organisation #28

Closed
2 tasks done
milanmlft opened this issue Aug 19, 2024 · 2 comments · Fixed by #50
Closed
2 tasks done

Review file organisation #28

milanmlft opened this issue Aug 19, 2024 · 2 comments · Fixed by #50
Assignees
Labels
design Design, scoping and ToR work

Comments

@milanmlft
Copy link
Member

milanmlft commented Aug 19, 2024

Definition of Done / Acceptance Criteria

We have reviewed the current organisation of configuration and source files and determined whether it's the most optimal setup.

Testing

  • All tests should still pass
  • Pre-processing scripts should still run successfully

Documentation

No response

Dependencies

No response

Details and Comments

It might make sense to move the shiny app to a subdirectory of this repo and have the configuration and deployment files (.env, docker-compose.yml, ...) and the pre-processing scripts (currently in dev/ subfolders) live in the root of the repo.

Work out whether we think changing the structure is worthwhile.

Copy link

linear bot commented Aug 19, 2024

SAF-645 Review file organisation

Definition of Done / Acceptance Criteria

We have reviewed the current organisation of configuration and source files and determined whether it's the most optimal setup.

Testing

No response

Documentation

No response

Dependencies

No response

Details and Comments

It might make sense to move the shiny app to a subdirectory of this repo and have the configuration and deployment files (.env, docker-compose.yml, ...) and the pre-processing scripts (currently in dev/ subfolders) live in the root of the repo.

@milanmlft
Copy link
Member Author

milanmlft commented Aug 28, 2024

Suggestions:

  • Move dev/test_db to data/test_db
  • Move dev/omop_analyses/ and dev/test_db/*.R to scripts/
  • Add data and scripts to .Rbuildignore
  • Keep current package structure (i.e. don't move it to a subdir of the repo)

@milanmlft milanmlft self-assigned this Aug 30, 2024
@milanmlft milanmlft added the design Design, scoping and ToR work label Sep 2, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design, scoping and ToR work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant