Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker container to run Shiny app #26

Closed
1 of 2 tasks
Tracked by #27
milanmlft opened this issue Aug 19, 2024 · 2 comments · Fixed by #44
Closed
1 of 2 tasks
Tracked by #27

Add Docker container to run Shiny app #26

milanmlft opened this issue Aug 19, 2024 · 2 comments · Fixed by #44
Assignees

Comments

@milanmlft
Copy link
Member

milanmlft commented Aug 19, 2024

Definition of Done / Acceptance Criteria

We have a reproducible Docker container that can be used to run the app.

Testing

  • Add CI step to test if container can be built

Documentation

  • Add instructions on how to build and run container to the README

Dependencies

No response

Details and Comments

See https://engineering-shiny.org/build-yourself-safety-net.html#a-reproducible-environment for some helpful tips and advice.

Copy link

linear bot commented Aug 19, 2024

SAF-643 Add Docker container to run Shiny app

Definition of Done / Acceptance Criteria

We have a reproducible Docker container that can be used to run the app.

Testing

  • Add CI step to test if container can be built

Documentation

  • Add instructions on how to build and run container to the README

Dependencies

No response

Details and Comments

See https://engineering-shiny.org/build-yourself-safety-net.html#a-reproducible-environment for some helpful tips and advice.

@milanmlft
Copy link
Member Author

The way golem::add_dockerfile_with_renv() sets things up is by creating a deploy/ folder with the Dockerfile and a built copy of the package, which is used to install and run the package in the container.
💭 Could have an automated GitHub Actions workflow that triggers a new build of the package whenever we create a new release. So we have a production version of the package living in the deploy/ folder that only gets updated when creating a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant