-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add realistic test data #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this in @BaptisteBR! I just have a minor worry about the test data not being reproducible. Could you have a look at that? Some more documentation would also be nice 🙏
Co-authored-by: Milan Malfait <[email protected]>
…CLH-Foundry/omop-data-catalogue into baptistebr/realistic-test-data
71fd240
to
ed59327
Compare
@BaptisteBR I redacted the git history so that the sensitive data from the dummy CSV files is removed. I'm going to do a few last polishing steps and then merge this in |
Make sure the data in the database matches the local dummy files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaned up a few more bits and made some fixes to make sure we always get the same data.
@BaptisteBR I think this is good to go now, but I'll leave it up to you to merge after reviewing my changes and only if you agree with them 🙂
Here's a brief summary of what I did:
- Changed to
overwrite = TRUE
when writing tables to the database, to ensure consistency - Used dummy data in the data getters for development and added some sanity tests
- Added some additional sanity checks in
insert_dummy_tables.R
to make sure the data is consistent - Subsetting of test data
- Added some logging messages to the scripts
I added individual comments to the relevant lines to make it easier to see what changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice
It seems good! I'll try to produce more logging and tests for my next contributions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review from BaptisteBR before merging the pull request
Add OMOP dummy data (for MEASUREMENT and OBSERVATION tables).
New script to import dummy data.
New script to produce realistic data.
Import realistic test CSVs
Fixes #14