Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Logging/Monitoring breaks local development #28

Open
hqva opened this issue May 10, 2023 · 0 comments · May be fixed by #31
Open

Azure Logging/Monitoring breaks local development #28

hqva opened this issue May 10, 2023 · 0 comments · May be fixed by #31
Assignees
Labels
bug Something isn't working

Comments

@hqva
Copy link

hqva commented May 10, 2023

The Azure Logging code added in commit 687a199 seems to break local development (with local or remote data).

I assume we do not want Azure logging for local development, so perhaps reasonable to wrap the logging initialisation in an appropriate if statement (?if environment =?? or:

if os.environ.get("APPLICATIONINSIGHTS_CONNECTION_STRING"):
     from azure_log_exporter import setup_azurelog_exporter
     instrumentation_key = os.environ.get("APPLICATIONINSIGHTS_CONNECTION_STRING", default="")
     setup_azurelog_exporter(environment, app.server, instrumentation_key)

or similar?)

@hqva hqva added the bug Something isn't working label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants