From 5bdeadf4788473dc11984dff4a9225ee056e04ca Mon Sep 17 00:00:00 2001 From: Tony Arcieri Date: Wed, 29 Jun 2022 13:19:35 -0600 Subject: [PATCH] zeroize: add `#[ignore]` to flaky CString test This test relies on UB and is flaking out in certain cases: https://github.com/RustCrypto/utils/issues/774 It's unclear if the test failure indicates a genuine bug in the implementation, or is the result of a test with UB. However, in the meantime it shouldn't block users who would just like the test suite to run reliably. --- zeroize/tests/zeroize.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/zeroize/tests/zeroize.rs b/zeroize/tests/zeroize.rs index b59eabcc..32281c1c 100644 --- a/zeroize/tests/zeroize.rs +++ b/zeroize/tests/zeroize.rs @@ -166,7 +166,9 @@ fn zeroize_string_entire_capacity() { assert!(as_vec.iter().all(|byte| *byte == 0)); } +// TODO(tarcieri): debug flaky test (with potential UB?) See: RustCrypto/utils#774 #[cfg(feature = "std")] +#[ignore] #[test] fn zeroize_c_string() { let mut cstring = CString::new("Hello, world!").expect("CString::new failed");