Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

der: add GeneraString (or more) tag(s) #1511

Closed
zkonge opened this issue Sep 9, 2024 · 2 comments
Closed

der: add GeneraString (or more) tag(s) #1511

zkonge opened this issue Sep 9, 2024 · 2 comments

Comments

@zkonge
Copy link
Contributor

zkonge commented Sep 9, 2024

I also work with kerberos types.

Just like #1385 (comment) mentioned, the Tag::GeneralString is required for convenience.

It is mentioned in the https://www.oss.com/asn1/resources/asn1-made-simple/asn1-quick-reference/generalstring.html

GeneralString is too general to be implemented, therefore it is not recommended.

So an independent GeneralString type is not needed, but tags in enum is still valuable.

Going a step further, we should implement more tags in der::tag::Tag, then the AnyRef could parse more types?

@tarcieri
Copy link
Member

tarcieri commented Sep 9, 2024

Adding Tag::GeneralString is fine. Kerberos is a good use case.

Going a step further, we should implement more tags in der::tag::Tag, then the AnyRef could parse more types?

I would prefer to keep additions motivated by concrete use cases, rather than adding complexity for "completeness".

@zkonge
Copy link
Contributor Author

zkonge commented Sep 10, 2024

GeneralString is enough. Closed by #1512.

@zkonge zkonge closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants