Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Webpack into frontend development flow #718

Closed
lawal-olaotan opened this issue Feb 15, 2023 · 4 comments
Closed

Introducing Webpack into frontend development flow #718

lawal-olaotan opened this issue Feb 15, 2023 · 4 comments
Assignees
Labels
new feature Use this for new functionality, for changes about existing features use 'enhancement'.

Comments

@lawal-olaotan
Copy link
Contributor

Currently, in knetminer, the frontend development flow requires running the maven build script mvn clean install when any changes are made on the client side, which can be considered time-consuming. To solve this time-consuming development constraint, we should introduce Webpack into the frontend development flow and maven build to allow fast feedback when developing on the client side.

In addition, Introducing Webpack to knetminer current development flow help with cache bursting (the browser loads the newest version of our app, if it has been updated, instead of using a cached version.).

@lawal-olaotan lawal-olaotan added the new feature Use this for new functionality, for changes about existing features use 'enhancement'. label Feb 15, 2023
@lawal-olaotan lawal-olaotan self-assigned this Feb 15, 2023
@marco-brandizi
Copy link
Member

More in general, the current Maven architecture is way too cumbersome for the current use we make of the code, I've added #719 about that.

Possibly, incremental Javascript builds could be added to that refactoring, if we can find a way to cause aratiny-client (or its future equivalent) to auto-reload the test instance as its files changed (I know the Maven/Jetty plug-in supports that, but I've never tried).

For the moment, one way to speed up things is:

stop aratiny-client
cd <client-base>
mvn install
cd <aratiny-client>
mvn jetty:run (the run-client.sh script has also 'clean', so it's slower)

Also, plug-ins like Clear Cache help with deleting the browser cache.

@Arnedeklerk
Copy link
Member

Unless there is a specific reason not to; let's prioritise this at the start of 5.7 to increase efficiency when working on other tickets.

@marco-brandizi regarding your ticket, I moved it into 5.7 too.

@Arnedeklerk
Copy link
Member

@lawal-olaotan, @marco-brandizi has written some instructions on how to prototype quicker using Aratiny. Could you try work this into your workflow and see whether it'd be necessary to still work on a different solution? Consider what we discussed that 5.7 may be the final release before major changes and the time may be better spent on other tickets

@Arnedeklerk
Copy link
Member

I'm closing this for now as I feel Marco's workflow increases productivity enough for the final minor update before 6.0...

@Arnedeklerk Arnedeklerk closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Use this for new functionality, for changes about existing features use 'enhancement'.
Projects
None yet
Development

No branches or pull requests

3 participants