New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyrax test spec bug affects tutorial #9

Open

fnibbit opened this issue Mar 2, 2020 · 2 comments

Collaborator

fnibbit commented Mar 2, 2020

https://github.com/RepoCamp/unc2020/wiki/Run-Test-Suite

the create image feature test fails like so:

Failures:

Create a Image a logged in user is expected to text "Add folder"
Failure/Error:
within('span#addfiles') do
attach_file("files[]", "#{Hyrax::Engine.root}/spec/fixtures/image.jp2", visible: false)
attach_file("files[]", "#{Hyrax::Engine.root}/spec/fixtures/jp2_fits.xml", visible: false)
end

Capybara::ElementNotFound:
Unable to find css "span#addfiles"
The styling of the add files button has changed, replacing span#addfiles with
div#add-files in create_image_spec.rb fixes it. I think this is a bug in hyrax's
auto-generated test files.

Collaborator Author

fnibbit commented Mar 2, 2020

https://github.com/RepoCamp/unc2020/wiki/Add-a-metadata-field,-with-feature-and-unit-tests The create_image_spec.rb code snippet contains the same bug

Collaborator Author

fnibbit commented Mar 6, 2020

pair with Bess to fix in hyrax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment