Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LevelSearchFlag to only include magic and awarded. #88

Open
RealistikDash opened this issue Apr 4, 2024 · 0 comments
Open

Refactor LevelSearchFlag to only include magic and awarded. #88

RealistikDash opened this issue Apr 4, 2024 · 0 comments
Labels
code quality Improvements or complaints regarding code quality or style.

Comments

@RealistikDash
Copy link
Member

This combination was added when the only other rating was EPIC. This was greatly extended in 2.2 to the point where merging these attributes is now clunky.

TLDR: Levels should store the LevelFeature flag themselves and not use LevelSearchFlag to decide whether a level is epic, mythical etc.
@RealistikDash RealistikDash added the code quality Improvements or complaints regarding code quality or style. label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improvements or complaints regarding code quality or style.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RealistikDash