Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement level comment likes. #51

Open
RealistikDash opened this issue Dec 10, 2023 · 0 comments
Open

Implement level comment likes. #51

RealistikDash opened this issue Dec 10, 2023 · 0 comments
Labels
code quality Improvements or complaints regarding code quality or style. enhancement New feature or request game feature Feature or behaviour related to the game client.

Comments

@RealistikDash
Copy link
Member

Currently, trying to like a level comment raises a NotImplementedError.

https://github.com/RealistikDash/RealistikGDPS/blob/d259ee3430a581df2e54f8ab468f3c26b602ec25/rgdps/api/gd/user_comments.py#L122-L132

This function can reuse existing backend infrastructure.

A rewrite of how this function is used could be useful. Instead of an if statement at the handler level, a single like_target function could be used with an enum.
@RealistikDash RealistikDash added enhancement New feature or request game feature Feature or behaviour related to the game client. code quality Improvements or complaints regarding code quality or style. labels Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improvements or complaints regarding code quality or style. enhancement New feature or request game feature Feature or behaviour related to the game client.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RealistikDash