Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genericise the level search repository. #41

Open
RealistikDash opened this issue Dec 8, 2023 · 0 comments
Open

Genericise the level search repository. #41

RealistikDash opened this issue Dec 8, 2023 · 0 comments
Labels
code quality Improvements or complaints regarding code quality or style.

Comments

@RealistikDash
Copy link
Member

Currently, the API for searching levels has been very clearly influenced by the search endpoint.
https://github.com/RealistikDash/RealistikGDPS/blob/85bd1a13ad78df1122001b2837b54fb996d14ea6/rgdps/repositories/level.py#L567-L583
This is a design issue we wish to avoid to make code as reusable as possible.

Fields such as search_type and followed_list are very clearly logic related and necessitate game knowledge to understand fully. Instead, they should be handled through params such as (take these as examples and not requirements): ignored_levels, required_levels, ignored_user_ids etc. The rest should be handled by the corresponding usecases.

@RealistikDash RealistikDash added the code quality Improvements or complaints regarding code quality or style. label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvements or complaints regarding code quality or style.
Projects
None yet
Development

No branches or pull requests

1 participant