-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream gamecontrollerdb.txt
mappings
#909
Comments
We have found that the upstream gamecontrollerdb maintainers to not be easy to work with when trying to submit PRs in the past. Easier to just maintain our own. |
@r3claimer hi :-) i'm a maintainer of the upstream gamecontrollerdb ! glad to work with you (or anyone else involved) to this end :-) |
one problem, will be whom is authoritative source for the mapping of a given handheld. So either there will be discussion around that, or distros will end up using different VID/PID/names to their own needs, but then it's not really different from what we already do... also, while the gamecontroller db is good for usb/bluetooth devices, so that the mapping is correct as soon as you connect it, for handheld, it's not that usefull, as the builtin controller can only be used with the distro it's running on |
the authoritative mapping format is prescribed by SDL. regardless of who serves the data or how, there should be no ambiguity in the data or it's format: https://github.com/mdqinc/SDL_GameControllerDB?tab=readme-ov-file#mapping-guide
this is a fair concern, but the upstream data is maintained and will not be changed trivially. there's no reason that concern can't move upstream. if this is actually a provable problem, the data can both exist upstream for past and future projects relying on it, and ROCKNIX can keep it's downstream overrides. your remaining arguments don't hold from my perspective, especially regarding button layout variation (south vs east) which should not be handled at the mapping level. the actual issue, which is categorizing and enumerating controls for best compatibility regardless of downstream use case, is needlessly complicated by fragmenting the source of the data. if ROCKNIX contributors are not following SDL's mapping scheme i suppose that's as good a reason as any for contributions not to move upstream, which is unfortunate. |
Is there a compelling reason
gamecontrollerdb.txt
changes are not upstreamed to the source repo https://github.com/mdqinc/SDL_GameControllerDB ?I suppose if there are udev drivers or other changes that make ROCKNIX different than a generic distro this might cause compatibility conflict but surely this is not the case for all handheld device controls ? I think it would be ideal for as many mappings as possible to move upstream
The text was updated successfully, but these errors were encountered: