-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SamplerV2 #488
Comments
nb: The relevant function is For more info on the migration, see https://docs.quantum.ibm.com/api/migration-guides/qiskit-1.0-features#qiskitprimitives and https://github.com/Qiskit/qiskit-ibm-runtime?tab=readme-ov-file#primitive-versions. |
Tracking issue from Qiskit Aer to support primitives V2: Qiskit/qiskit-aer#2078 EDIT: Actually, there's no reason to wait on Aer to add support for primitives V2, but we might want to wait on Aer before we adopt the new primitives entirely. I've opened #503 as a follow up to this issue for that reason. |
Actually (reversing course a second time), it seems like we do indeed need to wait for Aer to support SamplerV2 if we are to provide automated tests of this feature, because Qiskit's implemention throws an error: |
Then again, we can provide a smoke test by only executing the circuits that do not contain any mid-circuit measurements. This might be worth doing, as long as we also manually test the code using Qiskit Runtime. |
An alternative would be to use |
* Add support for `SamplerV2` Fixes #488 * Use qiskit branch with fixed `BackendSamplerV2` * Bump qiskit-aer version; restore qiskit version bounds * Update pyproject.toml * Update pyproject.toml * Update pyproject.toml * Bump nbmake minimum version nbmake < 1.4.3 depends on pydantic < 2.0 (see treebeardtech/nbmake#109), but qiskit-ibm-runtime implicitly requires pydantic > 2.5 (see Qiskit/qiskit-ibm-runtime#1539). * Revert "Update pyproject.toml" This reverts commit b4de1c2. * Update README, pyproject.toml * Mark SamplerV2 branch as `pragma: no cover` This annotation can be removed once qiskit 1.1 is released * Updates * Tweak release note
The circuit cutting post-processing uses the
SamplerResult
objects output fromSamplerV1
directly; however,SamplerV2
will returnPrimitiveResult
objects, so our post-processing should support both types of outputs from the two different sampler interfaceshttps://github.com/Qiskit/qiskit/blob/61181ce0681129f9a1d5af43122484f8b6da1bbc/qiskit/primitives/base/base_sampler.py#L231
The text was updated successfully, but these errors were encountered: