Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve print form functionality #226

Closed
QAZIMAAZARSHAD opened this issue Jun 21, 2021 · 16 comments · Fixed by #235 or #245
Closed

Improve print form functionality #226

QAZIMAAZARSHAD opened this issue Jun 21, 2021 · 16 comments · Fixed by #235 or #245
Assignees
@royalleads15 @RiyaGupta89
Labels
enhancement New feature or request 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21.Points will be 10 LGMSOC21 This issue will be considered for LGM-SOC 21

Comments

@QAZIMAAZARSHAD
Copy link
Owner

Print function prints the entire web page including header, footer, captcha, etc.

It should work properly and only the submitted form should be printed.
@QAZIMAAZARSHAD QAZIMAAZARSHAD added enhancement New feature or request 🤩 Up for Grab This issue will is not assigned ! Grab It ! 🟥 Level4 This issue will be considered as level 4 issue for LGM-SOC 21.Points will be 45. LGMSOC21 This issue will be considered for LGM-SOC 21 labels Jun 21, 2021
@royalleads15
Copy link
Contributor

Sir I think I can improve it more, assign me so that I can continue.

@RiyaGupta89
Copy link
Contributor

Where is the print function? I can't find it.

@QAZIMAAZARSHAD
Copy link
Owner Author

Where is the print function? I can't find it.

In the header of home.html.

@nlok5923 nlok5923 removed the 🤩 Up for Grab This issue will is not assigned ! Grab It ! label Jun 21, 2021
@RiyaGupta89
Copy link
Contributor

Where is the print function? I can't find it.

In the header of home.html.

Sorry, I still cannot see it. Is the print button not there in the home page on the website? You can tell me the location of it and I'll find it.

@RiyaGupta89
Copy link
Contributor

Oh, I saw it. Okay. No need to answer now.

@RiyaGupta89
Copy link
Contributor

@QAZIMAAZARSHAD I removed footer part. Tell me about the header, from where you want it to print? from mandatory specifications? Or from somewhere else?

@RiyaGupta89
Copy link
Contributor

@QAZIMAAZARSHAD From form 6?

@QAZIMAAZARSHAD
Copy link
Owner Author

Yes from form 6 to I am aware signature.

@RiyaGupta89
Copy link
Contributor

print2
print1
Have a look, is it okay? Or you want something more to exclude from the print page?

@royalleads15 royalleads15 mentioned this issue Jun 21, 2021
Merged
@QAZIMAAZARSHAD
Copy link
Owner Author

print2
print1
Have a look, is it okay? Or you want something more to exclude from the print page?

@RiyaGupta89 the printed form should include filled details.

This was the mistake in @royalleads15 latest PR and also print form function is printing everything including the footer in mobile view.

@RiyaGupta89 RiyaGupta89 mentioned this issue Jun 22, 2021
Merged
@RiyaGupta89
Copy link
Contributor

@QAZIMAAZARSHAD My PR resolves all of these issues. Please review it.

@RiyaGupta89
Copy link
Contributor

@QAZIMAAZARSHAD Is there something more to change?

@QAZIMAAZARSHAD
Copy link
Owner Author

QAZIMAAZARSHAD commented Jun 22, 2021 •
edited
Loading

@QAZIMAAZARSHAD Is there something more to change?

Submitted details in the form are not getting printed.

@RiyaGupta89
Copy link
Contributor

@QAZIMAAZARSHAD Is there something more to change?

Submitted details in the form are not getting printed.

If the user is printing the form before submitting it then the details are getting printed. After that its not getting printed before the form refreshes.

@QAZIMAAZARSHAD
Copy link
Owner Author

@QAZIMAAZARSHAD Is there something more to change?

Submitted details in the form are not getting printed.

If the user is printing the form before submitting it then the details are getting printed. After that its not getting printed before the form refreshes.

No even without submitting it is not printing the entered details.

Share screenshots if so.

@royalleads15 royalleads15 mentioned this issue Jun 24, 2021
Merged
@QAZIMAAZARSHAD QAZIMAAZARSHAD added 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21.Points will be 15 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21.Points will be 10 and removed 🟥 Level4 This issue will be considered as level 4 issue for LGM-SOC 21.Points will be 45. 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21.Points will be 15 labels Jun 24, 2021
@QAZIMAAZARSHAD
Copy link
Owner Author

@royalleads15 and @RiyaGupta89 you can work on issue #246 to fix the bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@royalleads15 royalleads15

@RiyaGupta89 RiyaGupta89

Labels
enhancement New feature or request 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21.Points will be 10 LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Milestone
No milestone
4 participants
@nlok5923 @QAZIMAAZARSHAD @royalleads15 @RiyaGupta89