Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet address displayed in lowercase #458

Open
ivanlewin opened this issue Nov 11, 2021 · 3 comments
Open

Wallet address displayed in lowercase #458

ivanlewin opened this issue Nov 11, 2021 · 3 comments

Comments

@ivanlewin
Copy link
Contributor

Describe the Bug
Wallet addresses appear in lowercase (that is, a combination of numbers and only lowercase letters)

To Reproduce
Open any profile and see the address (under the full name) is in lowercase

Expected Behavior
Wallet addresses should display with the correct casing, to prevent issues when checking it against the submitted picture and video

Screenshots
image

Device and Browser Information
Google Chrome v95 on Windows 10, Google Chrome v95 on Android 11

@bilinkis
Copy link
Contributor

bilinkis commented Dec 11, 2021

Upper or lower case don't affect Ethereum Addresses. I don't see the point on changing this.

@ivanlewin
Copy link
Contributor Author

I was thinking it makes it easier to read and compare it to, say, the address displayed on the submissions.

After posting this issue I went into the code and saw that this is the way the addresses are fetched from the API so maybe it's not that simple to change

@aahna-ashina
Copy link
Contributor

aahna-ashina commented Dec 13, 2021

@ivanlewin I think what you are suggesting is to encourage new profiles to use the lower-case variant of their ETH address when they record their video (as it's currently displayed on the website), is that correct? Or are you suggesting the reverse?

Screen Shot 2021-12-13 at 9 59 17 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants