From e39736a8882f817702e9e187a3b7a3c95409b834 Mon Sep 17 00:00:00 2001 From: Stephan Min Date: Wed, 1 Nov 2023 10:22:49 -0400 Subject: [PATCH] address more comments --- script/DeployAndRedeemTrait.s.sol | 2 +- test/ERC7498-DynamicTraits.t.sol | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/script/DeployAndRedeemTrait.s.sol b/script/DeployAndRedeemTrait.s.sol index 3519460..67aab07 100644 --- a/script/DeployAndRedeemTrait.s.sol +++ b/script/DeployAndRedeemTrait.s.sol @@ -54,7 +54,7 @@ contract DeployAndRedeemTrait is Script, Test { TraitRedemption[] memory traitRedemptions = new TraitRedemption[](1); // trait key is "hasRedeemed" - bytes32 traitKey = bytes32(bytes(string("hasRedeemed"))); + bytes32 traitKey = bytes32("hasRedeemed"); // previous trait value (`substandardValue`) should be 0 bytes32 substandardValue = bytes32(uint256(0)); diff --git a/test/ERC7498-DynamicTraits.t.sol b/test/ERC7498-DynamicTraits.t.sol index aa4ee3d..2a3c269 100644 --- a/test/ERC7498-DynamicTraits.t.sol +++ b/test/ERC7498-DynamicTraits.t.sol @@ -76,7 +76,7 @@ contract ERC7498_DynamicTraits is BaseRedeemablesTest { TraitRedemption[] memory traitRedemptions = new TraitRedemption[](1); // trait key is "hasRedeemed" - bytes32 traitKey = bytes32(bytes(string("hasRedeemed"))); + bytes32 traitKey = bytes32("hasRedeemed"); // previous trait value (`substandardValue`) should be 0 // new trait value should be 1