Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do mineflayer's Block, Item, Recipe, RecipeItem and Biome classes belong here ? #2

Closed
rom1504 opened this issue May 12, 2015 · 2 comments
Closed

Do mineflayer's Block, Item, Recipe, RecipeItem and Biome classes belong here ? #2

rom1504 opened this issue May 12, 2015 · 2 comments

Comments

@rom1504
Copy link
Member

rom1504 commented May 12, 2015

They don't seem too specific to mineflayer, it might makes sense to put them here.

Could they be used by other projects ? for example in prismarine-server ? @wtfaremyinitials @roblabla what do you think ?

I'm talking about the block.js, item.js ,... files in https://github.com/andrewrk/mineflayer/tree/master/lib
@rom1504
Copy link
Member Author

rom1504 commented Aug 23, 2015

I'm not sure about the answer to that issue. But we should be careful not to make node-minecraft-data specific to mineflayer.

@rom1504
Copy link
Member Author

rom1504 commented Nov 14, 2015

So we went in an other direction : putting these more high level (dynamic) helpers in their one module and keeping node-minecraft-data more static/low-level. See PrismarineJS/mineflayer#336

@rom1504 rom1504 closed this as completed Nov 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rom1504