Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 369 - Adds homework 9 from JT's class #383

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Issue 369 - Adds homework 9 from JT's class #383

merged 8 commits into from
Jan 15, 2025

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Jan 10, 2025 •
edited
Loading

Description

adds example directory solid-solid-interface from the computational seismology class in at princeton.

Requires #382 to be merged first.

  • Also increases resolution of the VTK output images to 2560x2560 pixels.

Issue Number

Closes #369

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@lsawade lsawade changed the base branch from main to devel January 10, 2025 23:14
Rohit-Kakodkar
Rohit-Kakodkar approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

docs/source_description/source_discription.rst Outdated Show resolved Hide resolved
examples/solid-solid-interface/README.md Outdated Show resolved Hide resolved
examples/solid-solid-interface/README.md Show resolved Hide resolved
@lsawade lsawade merged commit f22674a into devel Jan 15, 2025
3 of 6 checks passed
@lsawade lsawade mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icui icui icui approved these changes

@Rohit-Kakodkar Rohit-Kakodkar Rohit-Kakodkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement example from class (should not take long)
3 participants
@lsawade @Rohit-Kakodkar @icui