From cc0ccae4272184ba39fa149ea91df34078048773 Mon Sep 17 00:00:00 2001 From: Chris Wentland Date: Mon, 21 Aug 2023 15:11:38 -0700 Subject: [PATCH 1/3] proposed solution to #151 --- include/pressiodemoapps/swe2d.hpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/pressiodemoapps/swe2d.hpp b/include/pressiodemoapps/swe2d.hpp index 082231a1..43ccf764 100644 --- a/include/pressiodemoapps/swe2d.hpp +++ b/include/pressiodemoapps/swe2d.hpp @@ -128,7 +128,8 @@ create_problem_eigen(const mesh_t & meshObj, CustomBCsFunctorLeft && customBCsLeft, CustomBCsFunctorFront && customBCsFront, CustomBCsFunctorRight && customBCsRight, - CustomBCsFunctorBack && customBCsBack) + CustomBCsFunctorBack && customBCsBack, + int /*unused*/) { if (problemEnum != Swe2d::CustomBCs){ From 92a69d17df559eb261e1e548b7255bdce5e2b7fd Mon Sep 17 00:00:00 2001 From: Francesco Rizzi Date: Wed, 23 Aug 2023 14:00:29 -0700 Subject: [PATCH 2/3] fix default param --- include/pressiodemoapps/swe2d.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/pressiodemoapps/swe2d.hpp b/include/pressiodemoapps/swe2d.hpp index 43ccf764..37e016d6 100644 --- a/include/pressiodemoapps/swe2d.hpp +++ b/include/pressiodemoapps/swe2d.hpp @@ -129,7 +129,7 @@ create_problem_eigen(const mesh_t & meshObj, CustomBCsFunctorFront && customBCsFront, CustomBCsFunctorRight && customBCsRight, CustomBCsFunctorBack && customBCsBack, - int /*unused*/) + int icFlag = 0 ) { if (problemEnum != Swe2d::CustomBCs){ From 4e18b287b07235c94d987943dfe83e9cdcbeb8f7 Mon Sep 17 00:00:00 2001 From: Francesco Rizzi Date: Wed, 23 Aug 2023 14:01:32 -0700 Subject: [PATCH 3/3] add mark --- include/pressiodemoapps/swe2d.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/pressiodemoapps/swe2d.hpp b/include/pressiodemoapps/swe2d.hpp index 37e016d6..1632d34f 100644 --- a/include/pressiodemoapps/swe2d.hpp +++ b/include/pressiodemoapps/swe2d.hpp @@ -129,7 +129,7 @@ create_problem_eigen(const mesh_t & meshObj, CustomBCsFunctorFront && customBCsFront, CustomBCsFunctorRight && customBCsRight, CustomBCsFunctorBack && customBCsBack, - int icFlag = 0 ) + [[maybe_unused]] int icFlag = 0 ) { if (problemEnum != Swe2d::CustomBCs){