Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting trustanchorfile will override trustanchros #14999

Open
2 tasks done
cmouse opened this issue Dec 27, 2024 · 3 comments
Open
2 tasks done

Setting trustanchorfile will override trustanchros #14999

cmouse opened this issue Dec 27, 2024 · 3 comments
Assignees
Milestone

Comments

@cmouse
Copy link
Contributor

cmouse commented Dec 27, 2024

Short description

When trustanchorfile is set in the yaml config file, all trustanchors are ignored.

Environment

  • Operating system: Ubuntu 24.04
  • Software version: 5.1.3
  • Software source: PowerDNS Repository

Steps to reproduce

  1. Configure recursor with trustanchorfile and trustanchors
  2. Run rec_control get-tas

Expected behaviour

See all configured trust anchors

Actual behaviour

You only see what it is in trustanchorfile

@rgacogne rgacogne added the rec label Dec 27, 2024
@rgacogne
Copy link
Member

I'm not convinced the current behaviour is a bug, but at the very least the documentation is wrong: Reads all DS and DNSKEY records from fname (a BIND zone file) and adds these to the Trust Anchors while we actually replace any existing Trust Anchors.

@cmouse
Copy link
Contributor Author

cmouse commented Dec 27, 2024

From admin point of view this is problematic behaviour, on the other hand you want to be able to use the system shipped trust anchor file, but the anchor file setting only accepts a file. So if you need to add some extra TAs, you either have to modify a system shipped file, you need to have automation that merges the system shipped file with your TAs, or you have to manually convert the system shipped TA into a trustanchor setting.

@omoerbeek omoerbeek self-assigned this Jan 6, 2025
@omoerbeek
Copy link
Member

I was worried this would be a regression introduced by the YAML setting code, but the present behavior (TA's read from file overriding all existing TA's, including root trust anchors) is already present since the introduction of this feature in 4.2.0.

I do follow your reasoning that merging the TA's defined an external file and the settings would be better, but it would introduce a behavior change, so extra care is needed. Anyway, not something for 5.2.0, lets revisit for the next release cycle.

@omoerbeek omoerbeek added this to the rec-5.3.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants