Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul cron-notify idle #1

Open
PhrozenByte opened this issue Sep 30, 2017 · 0 comments
Open

Overhaul cron-notify idle #1

PhrozenByte opened this issue Sep 30, 2017 · 0 comments

Comments

@PhrozenByte
Copy link
Owner

PhrozenByte commented Sep 30, 2017

  • If registering the sleep/resume callback is successful, don't wake up once a hour to check the state (this is a borg-notify leftover where it was possible to run multiple instances at the same time)
    • Open question: What should we do if registering the sleep/resume callback isn't possible?
  • Never sleep longer (CronNotify._sleepTime) than the next execution time (i.e. when cron = * * * * * and sleepTime = 3600, you must never sleep longer than 60 sec, depending on the current time)
  • Improve class interface to have definite resetTimer and clearTimer methods per timer (next execution timer, notification timeout timer, dismiss timer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant