Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duble globbing #110

Open
spirillen opened this issue Dec 17, 2024 · 6 comments · May be fixed by #111
Open

Prevent duble globbing #110

spirillen opened this issue Dec 17, 2024 · 6 comments · May be fixed by #111
Labels
bug Something isn't working

Comments

@spirillen
Copy link

For what I can tell, you should not be using several double quotes inside the same echo command to use the VAR

echo -e "\nFile \"$file\" not proerly sorted!\n\nDiff between current and the correct version:" 1>&2

The following line should be doing the same, but with less potential of failures

echo -e "\nFile $file not properly sorted!\n\nDiff between current and the correct version:" 1>&2

PS: you have a typo in proerly sed s/proerly/properly/

@dosubot dosubot bot added the bug Something isn't working label Dec 17, 2024
@PeterDaveHello
Copy link
Owner

@spirillen Thank you for pointing this out and providing suggestions! Rally appreciates your input. Would you be interested in opening a PR to address this issue?

@spirillen
Copy link
Author

Would you be interested in opening a PR to address this issue?

sure, just let me eat at first, and I'll update the scripts for you.

Would you be interested in changing you nslookup into PyFunceble testing? I can make it test on dns-lookup-only if you like and then change your DNS (resolve.conf) to trustworthy dns recursors.

spirillen added a commit to foreign-affairs/url-shorteners that referenced this issue Dec 17, 2024
@spirillen spirillen linked a pull request Dec 17, 2024 that will close this issue
@PeterDaveHello
Copy link
Owner

Thanks! Do you have more information about what the migration will look like? I have no idea yet, but I am open to discussing it.

@spirillen
Copy link
Author

That would be a rather long script as PyFuncebles approach are different in almost any ways, and it will involve a number of scripts.

Instead I will mention the biggest benefits.

  • In can still be executed within GHA, as the total size are limited.
  • You can replace the DNS queries over UDP:53 with some rather reliable DoH:443(*) queries thanks to the Python Recursor implementation
  • You can, in time, use the (Hidden Beta) platform to speed up and share test results with other PyFunceble user.
  • You will by default have your test results separated into tree results, ACTIVE, INACTIVE and INVALID. These results groups are build as plan text lists, and not relevant for you, but IP as well. These can be generated as RFC:952 (hosts) formation as well
  • Results can be list alphabetically or hierarchically (personal preferred format)
  • You append the test to include WHOIS and HTTP(s)

And a lot more

* By switching from UDP to DoH we can change your DNS recursers to 100% trust worthy reccursers that do their own fresh AUTH lookup, and do not server manipulated or stalled data. in example, 8.8.n.n are not doing their own DNS queries but relies on other third party, they serves manipulated and stalled (More than 1 years old results, from no longer registered or active domains), the same goes for the Chinese and Russian DNS you have set up.
By switching to DoH on these kind of test, I've noticed there are far less DNS drops!! go figures, but it seems like a more stable and reliable setup for many and fast queries, where UDP based setups tent to operate with a lover allowed query limit.

The DNS recursors I have in mind is, 9.9.9.10+149.112.112.112, 91.239.100.100 (censurFriDNS: anycast), for load distribution 89.233.43.71 (censurFriDNS: unicast), these are not logging you, the serves only fresh and unaltered responses.
A limitation in this change is, you can only use one type of DNS protocols, they can't be mixed.

@PeterDaveHello
Copy link
Owner

Thanks for introducing PyFunceble. It certainly seems impressive!

I'm just a bit cautious about adding complexity and dependencies to our setup, as it might feel like using a big tool for a small task. However, I'm open to considering it if we encounter specific issues that could benefit from its capabilities.

@spirillen
Copy link
Author

It's up to you, the thing you would cane is the switch to trust worthy DNS in this case, forget the rest, as you said, all the other might not be to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants