From 36f748a995fb8a04ae649d8c1bcee088c7ddf8ea Mon Sep 17 00:00:00 2001 From: Haochen Wang Date: Fri, 24 Jan 2025 15:37:03 -0500 Subject: [PATCH 1/6] Are runtime tests actually required in CI?? --- runtime/tests/Test_NullQubit.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/runtime/tests/Test_NullQubit.cpp b/runtime/tests/Test_NullQubit.cpp index 1fc4b90a24..3dd5f35fad 100644 --- a/runtime/tests/Test_NullQubit.cpp +++ b/runtime/tests/Test_NullQubit.cpp @@ -28,6 +28,7 @@ TEST_CASE("Test success of loading a device", "[NullQubit]") { std::unique_ptr driver = std::make_unique(); CHECK(loadDevice("NullQubit", "librtd_null_qubit" + get_dylib_ext())); + CHECK(1 == 0); } TEST_CASE("Test __catalyst__rt__device_init registering device=null.qubit", "[NullQubit]") From 33bc47116e55c313b897c1de69151163cf61e302 Mon Sep 17 00:00:00 2001 From: Haochen Wang Date: Fri, 24 Jan 2025 15:50:07 -0500 Subject: [PATCH 2/6] add a CHECK(1==0) to all runtime test files --- runtime/tests/Test_OpenQasmBuilder.cpp | 1 + runtime/tests/Test_OpenQasmDevice.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/runtime/tests/Test_OpenQasmBuilder.cpp b/runtime/tests/Test_OpenQasmBuilder.cpp index e963a1f8d1..a29d7f621a 100644 --- a/runtime/tests/Test_OpenQasmBuilder.cpp +++ b/runtime/tests/Test_OpenQasmBuilder.cpp @@ -27,6 +27,7 @@ using namespace Catalyst::Runtime::Device::OpenQasm; TEST_CASE("Test lookup openqasm gate names from QIR -> OpenQasm map", "[openqasm]") { // Check lookup supported gates + CHECK(1 == 0); CHECK(lookup_qasm_gate_name("PauliX") == "x"); CHECK(lookup_qasm_gate_name("Hadamard") == "h"); CHECK(lookup_qasm_gate_name("CNOT") == "cnot"); diff --git a/runtime/tests/Test_OpenQasmDevice.cpp b/runtime/tests/Test_OpenQasmDevice.cpp index 1c1c5e97cd..803a2e2c7c 100644 --- a/runtime/tests/Test_OpenQasmDevice.cpp +++ b/runtime/tests/Test_OpenQasmDevice.cpp @@ -86,6 +86,7 @@ TEST_CASE("Test BraketRunner", "[openqasm]") { auto &&results = runner.runCircuit(circuit, "default", 100); CHECK(results.find("GateModelQuantumTaskResult") != std::string::npos); + CHECK(1 == 0); } SECTION("Test BraketRunner::Probs()") From 98e3b064e2767253983e71972145d2bd308d9b99 Mon Sep 17 00:00:00 2001 From: Haochen Wang Date: Mon, 27 Jan 2025 10:45:04 -0500 Subject: [PATCH 3/6] CI From 9711272ef606ef37efd2ef815b23494df12f74d7 Mon Sep 17 00:00:00 2001 From: Haochen Wang Date: Mon, 27 Jan 2025 10:48:47 -0500 Subject: [PATCH 4/6] make runtime coverage required --- .github/workflows/check-catalyst.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/check-catalyst.yaml b/.github/workflows/check-catalyst.yaml index f460ce4dd1..279dc7422f 100644 --- a/.github/workflows/check-catalyst.yaml +++ b/.github/workflows/check-catalyst.yaml @@ -687,6 +687,8 @@ jobs: COMPILER_LAUNCHER="" \ make coverage-runtime mv runtime/build_cov/coverage.info coverage-${{ github.job }}.info + with: + fail_ci_if_error: true - name: Upload to Codecov uses: codecov/codecov-action@v4 From 00c31b9cbd22dfacbb7c56058384f00e589143db Mon Sep 17 00:00:00 2001 From: Haochen Wang Date: Mon, 27 Jan 2025 10:52:05 -0500 Subject: [PATCH 5/6] CI From 2d1146bd0f799ddb63a8bdbc3ab687a67e97df68 Mon Sep 17 00:00:00 2001 From: Haochen Wang Date: Mon, 27 Jan 2025 10:56:22 -0500 Subject: [PATCH 6/6] remove tag --- .github/workflows/check-catalyst.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/check-catalyst.yaml b/.github/workflows/check-catalyst.yaml index 279dc7422f..f460ce4dd1 100644 --- a/.github/workflows/check-catalyst.yaml +++ b/.github/workflows/check-catalyst.yaml @@ -687,8 +687,6 @@ jobs: COMPILER_LAUNCHER="" \ make coverage-runtime mv runtime/build_cov/coverage.info coverage-${{ github.job }}.info - with: - fail_ci_if_error: true - name: Upload to Codecov uses: codecov/codecov-action@v4