Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompute tags generates redundant tags #56

Open
oganm opened this issue Dec 8, 2022 · 2 comments
Open

precompute tags generates redundant tags #56

oganm opened this issue Dec 8, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@oganm
Copy link
Member

oganm commented Dec 8, 2022

Something splits reference subject role and just "role" into two separate tags

@oganm oganm added the bug Something isn't working label Dec 8, 2022
@jsicherman
Copy link
Collaborator

Dropping in to offer an eye:

That would be the expand tags stepping up the tree (reference subject role -> participant under investigation role -> role, Ontobee) (code responsible).

If it's not being dropped it's because there's (at least) one experiment annotated with "role" and not "reference subject role", otherwise no new unique chain would be found (code) and it would be filtered. I guess it's also possible that it expanded from something outside of Uberon too since "role" is used in quite a few ontologies (Ontobee).

Should be able to track this down by just grepling ("role") in cf.Base and cf.Val (or whatever they're called).

@oganm
Copy link
Member Author

oganm commented Feb 2, 2023

CHEBI: http://purl.obolibrary.org/obo/CHEBI_50906
BFO: http://purl.obolibrary.org/obo/BFO_0000023

no other term has the sole definition of "role" in our ontology definitions, neither seem to appear anywhere on the datasets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants