Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support search request cancellation #16

Open
arteymix opened this issue Jan 29, 2023 · 1 comment
Open

Support search request cancellation #16

arteymix opened this issue Jan 29, 2023 · 1 comment

Comments

@arteymix
Copy link
Member

arteymix commented Jan 29, 2023

When a new search is issued, we have to cancel the pending one to prevent a race condition. Presently, this means aborting the following requests: datasets, datasets number and datasets annotations.

This is supported by Axios, but not vuex-rest-api. It would be nice to be able to dispatch the store and include a signal to effectively cancel the dispatch later on, or have some built-in mechanism for binding the cancel state to the store. More details at https://axios-http.com/docs/cancellation

The native API for browser is AbortController.

@arteymix arteymix changed the title Support request cancellation Support search request cancellation Jan 29, 2023
@arteymix
Copy link
Member Author

arteymix commented Feb 3, 2023

Looks like this is in the planning in vuex-rest-api... from 3 years ago. christianmalek/vuex-rest-api#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant