Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple GUI improvements #100

Closed
3 tasks done
ppavlidis opened this issue May 7, 2024 · 6 comments
Closed
3 tasks done

Multiple GUI improvements #100

ppavlidis opened this issue May 7, 2024 · 6 comments
Assignees

Comments

@ppavlidis
Copy link

ppavlidis commented May 7, 2024

I'm just going to list these and separate issues can be made if need be, and I'll just update this issue with more suggestions for now.

  • In the 'expanded' row view, the short name should be listed again and made a link. The row above is visually 'detached' from the expanded region - it's hard to tell if it goes with the expanded view above, or below it, and the "up arrow" adds to the cognitive load to navigate, as does the fact that the title of the experiment in the expansion is larger than the text in the original row. Open to suggestions overall.
  • Show the curation status in the administrator's view. Pretty much all the information available here should be in the new browser as well.
  • Abbreviate the Description in the row expansion (some are very long), make it look tidier. e.g. 150 words or something.
@oganm
Copy link
Member

oganm commented May 15, 2024

Do you think removing the bottom shadow is good for better specifying that the details belong to the row above?

No bottom shadow
image

Double shadow (current version)
image

@oganm
Copy link
Member

oganm commented May 15, 2024

Another particularly annoying thing is the widths of elements changing between expanded and non-expanded views causing rows to shift on click.

image

see the difference in position between the expanded and shrunk version. Still trying to figure out what causes the difference

@ppavlidis
Copy link
Author

Shadow: seems a bit of a tossup to me but I've spent too much time looking at it so might not have the right perspective.

And yes, the shifting of the rows is something I wanted to mention as well, forgot.

@oganm
Copy link
Member

oganm commented May 15, 2024

Shifting rows is fixed in f488281

@oganm
Copy link
Member

oganm commented May 17, 2024

Second point is #75

That issue suggests upstream fixes are needed but the missing columns from the original browser are just "Status" and "Curation".

  • As far as I understand "Curation" just corresponds to needsAttention component being true or false which is available to everyone.
  • Currently implementing status would be a bit prohibitive since existence of those analyses would require one to ask for the results

@arteymix
Copy link
Member

arteymix commented May 26, 2024

Regarding curation status, I believe we expose it regardless of the user privileges. I will change this in the API to require at least GROUP_ADMIN.

PavlidisLab/Gemma#545

@oganm oganm closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants