From 5b723e4c55bccaf61eae670d041c7e431877bef8 Mon Sep 17 00:00:00 2001 From: Will Beasley Date: Fri, 10 Jan 2025 18:34:26 -0600 Subject: [PATCH] cran comments for v1.4.0 release ref #562 --- cran-comments.md | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 13382ee7..2fc01b19 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,22 +1,25 @@ Description =============================================== -This submission is primarily to address a failing test. -One of the test (out of hundreds) was missing `testthat::skip_on_cran()`. +This submission is primarily to address vignettes were calling an external server. +When that dev server had maintenance on +[Dec 13](https://www.stats.ox.ac.uk/pub/bdr/Rblas/MKL/REDCapR.out), Brian Ripley requested that +the vignettes be modified to comply with the CRAN policy that states +no external sources should be called. Thank you for taking the time to review my submission, and please tell me if there's something else I should do for CRAN. -Will Beasley Test environments ----------------------------------------------- -1. Local Ubuntu, R 4.4.1 -2. Local Win11, R 4.4.1 patched +1. Local Ubuntu, R 4.4.2 +2. Local Win11, R 4.4.2 patched 3. R-hub - 1. [Ubuntu Linux, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/11469699615/job/31917444604) - 2. [Windows Server, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/11469699615/job/31917445020) - 3. [MacOS, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/11469699615/job/31917445170) -4. [win-builder](https://win-builder.r-project.org/7m12AMR9sIC2//), development version. -5. [GiHub Actions R-CMD-check](https://github.com/OuhscBbmc/REDCapR/actions/workflows/check-release.yaml), Ubuntu 22.04 LTS + 1. [Ubuntu Linux, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/12719261459/job/35459171237) + 2. [Windows Server, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/12719261459/job/35459171426) + 3. [MacOS, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/12719261459/job/35459171708) +4. [win-builder](https://win-builder.r-project.org/O603j9cGa700), development version. +5. [GiHub Actions R-CMD-check](https://github.com/OuhscBbmc/REDCapR/actions/workflows/check-release.yaml), Ubuntu 24.04 LTS R CMD check results -----------------------------------------------