-
Notifications
You must be signed in to change notification settings - Fork 54
Add unit test for StraightSkeleton robustness #96
Comments
@strk so this is the ticket where I meant to place that comment...can we accomplish the level of precision testing you require for the relevant module with WKT inputs in fractional form? |
@danielcu888 I can't tell, possibly, you can try reverting the fix and triggering the bug with fractional WKT input. |
Sure, I'll try that @strk. @lbartoletti can I please be assigned to this whilst I am investigating what @strk has proposed? |
Thanks @lbartoletti this is now in progress. |
…t geometry in fractional form.
…lt in fractional form.
@strk I used the HEXWKB input of the simplified example that you posted in #89 to generate high precision WKT:
using the online converter: https://rodic.fr/blog/online-conversion-between-geometric-formats/ and generated the following results: which looks correct to me. Does this look correct to you? If so, then there is not much more that can be done since I can't seem to reproduce the issue (using high precision WKT tests). |
A fix for robustness issue reported in #89 was fixed with pull request #92 but no test came with the fix due to lack of WKB input (#94). This ticket is a reminder for adding the test when possible.
The text was updated successfully, but these errors were encountered: