Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value '1' has no effect for boolean API GET parameters #22

Closed
jojoob opened this issue Jul 7, 2022 · 1 comment · Fixed by #26
Closed

Value '1' has no effect for boolean API GET parameters #22

jojoob opened this issue Jul 7, 2022 · 1 comment · Fixed by #26

Comments

@jojoob
Copy link
Contributor

jojoob commented Jul 7, 2022

On line 302 in lib.php the boolean parameters sign, withmetadata and withpublications are set to '1'. This has no effect, at least with Opencast 11.8.

$query = '/api/events?sign=1&withmetadata=1&withpublications=1&filter=' . urlencode($seriesfilter);

Changing the parameter values to true works. But with withmetadata=true the request takes much longer (about 4 times longer) to complete on my test instance.

Beside the faulty code I noticed no (visible) bugs caused by it.

@justusdieckmann
Copy link
Contributor

Thank you very much for this issue!

It doesn't really cause bugs, but I guess they saw that it doesn't add the publications, and so they pulled the publications for every video separately. #26 fixes and removes that.

Cheers
Justus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants