Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solutions to intermediate evaluation by CVODE are leaking to algebraic loop solutions #1333

Open
rruusu opened this issue Oct 30, 2024 · 1 comment

Comments

@rruusu
Copy link

rruusu commented Oct 30, 2024

Description

The initial guesses for each algebraic loop evaluation are not based on the end of the last solver step. Instead, the initial guess is based on whatever result was last obtained by the previous RHS evaluation of the ODEs, which might be related to a trial step in Jacobian evaluation using difference quotient steps.

This results in both unnecessary noise to inputs in algebraic loops, as well as possible extra iterations.

Version and OS

  • Version: OMSimulator v2.1.2.post5-gce342b6-mingw-notlm-debug
  • OS: Windows 11, 64-bit
@rruusu
Copy link
Author

rruusu commented Oct 30, 2024

I will push a solution for this to my fork shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant