-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥🐛 Contextual tabs mechanism not working at all with Office.StartupBehavior.load #3052
Comments
Thank you for letting us know about this issue. We will take a look shortly. Thanks. |
Hi @wh1t3cAt1k, I did not repro this issue via your steps. Could you please provide a screen record video to help me understand how this issue works. Thanks! |
@ruijiaMS @RuizhiSunMS it's very easily reproducible using the steps / minimal repro repository from the bug description. Here is the video: |
Hi @wh1t3cAt1k , ReproMedia.mp4ReproMediaChrome.mp4 |
@yuc014 by any chance, do you use "disable caching" on the network tab your dev tools? Have you tried editing the workbook and waiting a little more time after the ribbon shows the first time? It replicates every single time for us. Could it be some sort of race / timing issue? |
Session ID when ribbon is showing: 5c885ecb-2a37-46ef-8459-9c3d90e58e42 Build: 16.0.16019.42303 URL is like this: When I reload the page, the ribbon is not showing. Session ID when not showing: 6f499cc9-401f-4f8a-99c5-3cf8115d82d7 Please check the logs and see the differences. Maybe a race, or intervention of other add-ins that you have installed - I am doing my experiment on a Chrome browser with 100% all-time cache cleared and no add-ins installed beside Script Lab. |
@ruijiaMS @yuc014 @Wenjun-Gong dear friends, we can't proceed with an important UX revamping with this issue present, may we please ask you to check the session IDs above and inform us of any resolutions or workarounds? Thank you. |
Hi @wh1t3cAt1k, sorry for the late response. My environment: And I also tried clean cache, uninstall my add-ins, edit workbook and wait for a while, still cannot repro. For the URL you provided, seems I cannot access your sharepoint. For the sessions you provided, I investigated it and didn't find typical error or something, attach session info below. So, it's a little bit weird, I guess maybe the build number difference? I will see whether I can repro on the workbook you share. |
Do you have a different build number for office on the web? Is it some sort of internal preview channel? I will share the workbook later, too |
@yuc014 can you try enabling cache in the browser too? Maybe this is important? |
@wh1t3cAt1k I tried my personal account (now Build:16.0.16109.42300), which should use the same channel with you. And tried enabling cache, but still cannot repro it. |
@yuc014 please see the below video if you can replicate or not. https://www.youtube.com/watch?v=wlJeVm2d9sk Please also consider asking a colleague to repro, there might be something else going on with your environment?
Again, the bug 100% repro when reopening existing workbooks, never replicates on new workbooks. My sessions: 4e144ce4-d255-44e9-95b3-510a0c55f17a - does not work (old workbook) @Wenjun-Gong @yuc014 I think if replication does not succeed maybe another team member can try from your side? I am open for a live call to demonstrate the issue and troubleshoot together with you, any time zone. Thank you. |
@yuc014 I also noticed that you have a lot of other add-ins installed. They may affect the picture that you're seeing. Velixo add-in (in my previous video) and Contoso add-in (in my repro example) were the only add-in I had installed. And please make sure you wait a little bit after reloading the page before clicking the add-in ribbon button. |
@ruijiaMS @yuc014 @Wenjun-Gong dear friends, I would like to follow up on the above - we're still blocked by this... |
@yuc014 to follow up further and see whether it can be reproed. @wh1t3cAt1k how frequently are you seeing this issue from your customers? |
Hi @wh1t3cAt1k, for the addin you provided in the video ("Velixo"), I can repro your issue. Additional information:
Will update when the bug has progress. |
@ruijiaMS thank you for the update. Just curious, will it be fixed at the office.js level, or is it the host app? If the latter, is there an approximate fix version? |
It is fixed in server side. Sorry for that we cannot get the approximate fix version yet, however, will post here if it comes up. |
Has it been deployed already? We are observing that our contextual tabs are not disappearing anymore in Excel Online. |
@wh1t3cAt1k |
Oh, I didn't know it replicated in Excel Desktop. For us the bug only reproduced on Excel Online 🤔🤔🤔 We'll do additional testing to make sure. |
@ruijiaMS @Wenjun-Gong our internal testing confirms that this particular ribbon issue is gone for us. Unfortunately on "corrupted" files that were created prior to your fix, it seems that the customers still need to remove and reinstall the add-in, but it's a one-off operation for old documents only. Great job MS team, you unblocked us in the direction of proper ribbon-oriented UI, and we cleared the side panel from a lot of buttons :) 💖 In this "epic", we are now hoping for your attention to #2877 and #3250 - with ribbon-oriented UI, we would like to depend on the status bar to avoid showing the side panel for long-running operations... Right now it's unreliable. This item I am gladly closing. |
@ruijiaMS @Wenjun-Gong possibly linked to #3476 – we're still experiencing intermittent ribbon "outages" but only on sideloaded add-ins. |
Hi @ruijiaMS, @RuizhiSunMS, the issue is still replicated for me in Excel Online (Chrome).
As a result, the side panel of the added add-in will appear, but in the ribbon, the tab won't be added: To make the tab appear in the ribbon:
Session ID: ad2d1f83-25c6-ddef-8cb9-ff28340e8a16 |
I am experiencing this problem constantly as well. It's only a problem on Excel Online. |
@Wenjun-Gong @ruijiaMS @RuizhiSunMS we're hoping for some attention to this problem as it really hinders our ability to pre-release test using a sideloaded manifest... |
@Wenjun-Gong can we please revisit this problem? It's a high-priority problem for us during internal testing and it produces a really bad impression on the customer in production. In addition to other arguments, this issue does not allow us to reliably E2E test our add-in since the ribbon does not always appear when we run our tests, and even multiple side panel reloads don't always help. |
I'm also constantly seeing this problem with Excel Online when using our store based add-in. Not a problem on Excel for Windows or Excel for Mac. |
Hi @wh1t3cAt1k and @gmichaud , team is looking at this issue. Thanks for your patience. |
Hi @wh1t3cAt1k , There is one thing that I want to confirm. Are you re-open this issue because of issue #3476 ? First for #3476 , we have transfer it to the right owned team previously. But I apologize that I didn't keep monitor it in time. I'll fully support you for solving this issue by keep driving this all the time in the following. Second for this issue. Please provided more repro detail information for us to tracking since we can't repro it.\ Sincerely, |
@ZYUN-MSFT not because of it, just because we discovered particular scenario is still replicable too. Our QA team (@JuliaKassina) will recheck and get back to you if it's still relevant. |
Hi @ZYUN-MSFT, I just re-tested the scenario shared above following the exact same steps and the issue is still replicated for me. Here are my replication steps:
As a result, the side panel of the added add-in will appear, but in the ribbon, the tab won't be added:
Please, let me know, if you need any other information regarding the issue. |
Hi @JuliaKassina , thanks for your reply. But unfortunatly I still cann't repro this problem. I delete my browser cache and try the steps you provided. And also the same office online version on Chrome Browser. Vel.mp4Please check my screen record above. Thanks. |
Hi @ZYUN-MSFT , thanks for your quick response and attaching the video recording. I've noticed the 'Script Lab, a Microsoft Garage project' add-in added in your Excel. Then tested my scenario having 'Script Lab, a Microsoft Garage project' add-in added, but it doesn't change the output, the issue is still replicated on my side (with and without 'Script Lab, a Microsoft Garage project' add-in). Can we have a screenshare meeting, where I will demonstrate you the issue (I'm available any working day from 7 AM to 6 PM UTC)? This issue is constantly happening for the whole our team and we need this to be resolved. |
@ZYUN-MSFT , I also noticed on your video recording, that there is the 'My organization' tab on the Office Add-ins window. While in my case, there is no such a tab. I additionally recorded another video with the Console opened. Please take a look, hope this will give you some additional info: https://www.loom.com/share/34996fd87217420a893ae778c3a38f28?sid=4446b1ac-5cf9-4081-ba4a-6f70b782be48 |
Hi @JuliaKassina , I think this issue is a little complex and we are investigating the root cause/right area of it. Please give us some time for investigation. And I will update the information here early next Week. I will back here when we need your help for more detail information. Thanks for your patience. |
Thanks @ZYUN-MSFT, Any further progress regarding the issue will be posted here in comments. |
I suggest to merge this with #3476 |
Duplicates with #3476 and team has active conversation there. So close this case as duplicated. |
Provide required information needed to triage your issue
Blocker for us. In Excel Online, when the start-up behaviour is set to "load", the contextual tab does not get displayed at all.
Therefore, upon first launch in a new workbook, the ribbon appears, but on subsequent opens of the same workbook, nothing gets shown.
Your Environment
Expected behavior
Ribbon appears
Current behavior
Ribbon does not appear
Steps to reproduce
Use this sample repository to reproduce: https://github.com/VelixoSolutions/repro-missing-ribbon-online
It only works on new workbooks you create but not on the existing ones where the start-up behaviour has been registered.
Context
We have an ongoing UI revamping effort where many of the flows will rely on contextual tabs instead of the (now-crowded) side panel. With this issue, it's completely impossible Online.
At the same time, we cannot change our start-up behaviour because our add-in attaches handlers and helper functionalities that need to run without the user explicitly clicking on the add-in button.
Useful logs
No error is shown in console, it simply does not appear. I also consider this a problem.
The text was updated successfully, but these errors were encountered: