Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review #76

Open
JudyZ98 opened this issue Oct 9, 2021 · 0 comments
Open

Peer Review #76

JudyZ98 opened this issue Oct 9, 2021 · 0 comments

Comments

@JudyZ98
Copy link

JudyZ98 commented Oct 9, 2021

This project is about exploring the relationships between operations of a public company and its stock returns. They are using the data NYSE SP500 company fundamentals from kaggle and trying to solve the mistakes that those people made when cracking this case.

(1) I like the part of “what we are doing differently”, but I think the only difference they propose is how to select data. Does it mean all other things they are going to do is the same as other people did from kaggle website? I think they should elaborate more on what are they going to do except for the data selection, for instance the methods like eda or which models they are plan to use.
(2) I also like that they go through the dataset you are going to use thoroughly and why they are choosing only part of it. They also proposed which data they are going to use for model testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant