From 0d75adb93a0aab1523597ec9d64d414831ff5f95 Mon Sep 17 00:00:00 2001 From: David Date: Tue, 24 Sep 2024 15:50:27 +0200 Subject: [PATCH] [FIX] Install Chrome fixed version to avoid sudden errors Odoo's approach with Runbots is to install a fixed version of Chrome and only when a new version is tested across all the supported code base they bump it. That way, they avoid sudden errors that would make the whole CIs collapse on tour tests. We can follow the guideline of Odoo's fixed versions for a minimum guarantee. --- Dockerfile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index 9bfa0ad..dc527e9 100644 --- a/Dockerfile +++ b/Dockerfile @@ -48,9 +48,10 @@ RUN curl -sSL https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add - && apt-get update -qq \ && DEBIAN_FRONTEND=noninteractive apt-get install -qq postgresql-client-12 -# Install Google Chrome for browser tests -RUN curl -sSL https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb -o /tmp/chrome.deb \ - && apt-get -y install --no-install-recommends /tmp/chrome.deb \ +# Install Google following Odoo's Runbot guideline https://github.com/odoo/runbot/blob/f8f435d468135486146a2e61e8d15d0f453c0e15/runbot/data/dockerfile_data.xml#L139-L140 +RUN curl -sSL https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_126.0.6478.182-1_amd64.deb -o /tmp/chrome.deb \ + && apt-get update -qq \ + && DEBIAN_FRONTEND=noninteractive apt-get install -qq -y --no-install-recommends /tmp/chrome.deb \ && rm /tmp/chrome.deb RUN add-apt-repository -y ppa:deadsnakes/ppa