-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for new ontology pbpko #2563
Comments
Dear @Crispae, Thank you for your submission. The review will be executed as a two stage process:
Usually, the review will result in an opportunity for you to improve the ontology. When the reviewer believes the ontology is ready for presentation to the OBO Operations Committee, they will present your ontology during an OBO Operations Call. This gives other members of the committee the opportunity to assess your work. When a decision is reached by the committee you will be informed here on the issue tracker. The process can take any number of weeks or months, depending on the case at hand. You will be informed once your ontology is loaded in the OBO NOR Dashboard. Good luck! |
@Crispae |
Ontology version reviewed: 2024-04-05 To begin with, the OBO dashboard states that PBPKO is only missing one definition, whereas in reviewing the pbpko.owl file using Protege, I see that many classes are missing definitions, for instance the many classes that appear directly under entity: Falv, fSA_exposed, FSkin_e, PCAir, PCPoor, PCRich, Qair, and others. Also, many other classes at deeper levels in the hierarchy, such as Observed, Predicted, Residual error magnitude, Fcecum, Fcolon, intestinal transit time, linear elimination, and others are all undefined. I can only imagine there is some error in the OBO Dashboard code. Ontology scope Was the ontology developed for a very specific purpose or community? Terms with the new ontology prefix The correct pattern that would match the OBO identifier scheme is: The identifier scheme must be fixed. Are there terms with the same meaning available in another OBO Foundry ontology? PBPKO has 'goodness of fit' (PKPBO:00328), an undefined type of 'Statistical Method' (PKPBO:00001, also undefined). The Ontology of Biological and Clinical Statistics has also a 'goodness of fit' (http://purl.obolibrary.org/obo/OBCS_0000030) subclass of 'inferential statistical data analysis' a type of planned process, defined as "An inferential statistical data analysis used to analyze how well a statistical model fits a set of observations; measures of goodness of fit typically summarize the discrepancy between observed values and the values expected under the model in question." The The Statistical Methods Ontology has 'goodness of fit statistical test' (http://purl.obolibrary.org/obo/STATO_0000191) defined as "A goodness of fit statistical test is a statistical test which aim to evaluate if a sample distribution can be considered equivalent to a theoretical distribution used as input." PBPKO should import their statistical test classes from an established ontology. Is there another OBO Foundry ontology whose scope covers any of the new terms? Correct use of imported terms Are imported terms in appropriate hierarchies, and do they preserve the term’s upper-level alignment? Are any additional axioms used for these terms correct in both a technical (e.g. passes reasoning) and substantive sense? Basic review of axiomatic patterns Are existential restrictions used correctly? (Typical mistakes include “R some (A and B and C)” to mean “(R some A and R some B and R some C)”). Appropriate use of object properties - Responsiveness to suggested changes - General Comments: |
Note to OBO Foundry members: Clearly the lexical matching test is a work in progress. |
@addiehl Thank you for your comments. We will address the mentioned issues. If we need further assistance, we are counting on OBO Foundry. |
Thank you for your comments, Apology for the delay in response, we need to restructure the ontology involving the domain experts. Following your suggestions, we reviewed our ontology PBPKO, which is being developed for the Physiologically Based Pharmacokinetic Modelling community, and made the necessary changes accordingly. We now adopted the ROBOT tool to develop the reviewed version of the PBPKO. We included the definition for the terms which were missing earlier. Though, some of the terms still does not have the definitions; we will address this issue soon on discussion with wider PBPK community of the project. The terms which had the same meaning were included from other OBO Foundry ontologies such as Gene Ontology, OBCIS, UBERON. And the annotation properties were included from IAO. Also, the BFO ontology which was imported and not used, was removed correctly to avoid any irregularities in the ontology. Also, documentation page was added for the ontology which can be viewed at https://crispae.github.io/pbpko/. It will be further enriched with detailed descriptions. NOTE: Please let us know if any additional changes are needed so we can further refine our ontology. |
Thanks for your detailed description of your revisions. I will review your changes and get back to you soon. |
Hi @addiehl, have you had a chance to look at this? |
Hi @addiehl, any update of review process . We need to implement this ontology in our ongoing project (PARC), some of our use cases depends on it. Please let us know, if further changes required, we will try to accommodate those ASAP. |
I apologize for my delay. Re-review comments:
Similarly the statistical terms should be imported, not created de novo.
Overall, the ontology structure is still closer to a mind map, rather than a proper ontology. Without addressing point 2 above, I cannot recommend this ontology should be admitted to the OBO Foundry. --Alex |
Also, one minor change that is required is that the Ontology IRI needs to be changed from This will enable the ontology to pass the new ontology dashboard check for URIs. |
In the initial description above, the Ontology Download Link is https://github.com/Crispae/pbpko/blob/main/pbpko.owl, but that URL no longer resolves. So I believe that the report from the New Ontology Requests Dashboard is out-of-date: https://obofoundry.org/obo-nor.github.io/dashboard/pbpko/dashboard.html. @Crispae Please provide us with a working Ontology Download Link. |
Thank you for the clarification, @addiehl ! We initially held off on using a PURL URL since we hadn't been assigned one, and the ontology is still under review. However, we will proceed with updating the Ontology IRI to http://purl.obolibrary.org/obo/pbpko.owl . |
@jamesaoverton thanks for catching this, here is the updated link with latest version https://github.com/Crispae/pbpko/releases/download/v1.0.1/pbpko_10_09_2024.owl |
@addiehl Thanks for your comments, For the Uberon terms, we’re currently in discussions with PBPK experts to determine the best approach. While importing all relevant terms from Uberon would address duplication, there's some concern that the standard Uberon terminology might not fully capture the contextual nuances specific to PBPK modeling. Definitions issue will be updated. Assigning object properties and applying restrictions are ongoing discussions with PBPK experts, and we will keep you updated on this and might come with next release of the ontology. Thanks for you feedback, and we’ll follow up with further updates. |
For the Uberon import, ideally you should create a list of the required Uberon terms and use a MIREOT tool to extract the terms you want from Uberon and their parents to root. You can use the extract tool in ROBOT with the MIREOT option or use ONTOFOX to do this. The resulting owl file of Uberon terms can be used as an imported ontology for pbpko or directly merged with pbpko. Keeping it as a separate file is preferable, as you can easily update it later if Uberon changes. You can also use the Ontology Development Kit to manage imports, but this is a more involved approach to set up. If there are nuances about anatomical parts you want to capture in pbpko that are missing from Uberon, there are a couple ways to reference related Uberon terms:
Keep in mind that ontologies that are part of the OBO Foundry commit to following the OBO Foundry Principles; these include Principle 5 Scope and Principle 10 Commitment to Collaboration. If you create your own anatomy terms (or statistical terms, for that matter), then you are expanding the scope of your ontology into the scope of Uberon. If instead you import Uberon terms and collaborate with the Uberon developers, then you comply with both principle 5 and 10. |
Hi @Crispae, are you working on the suggested revisions? |
Hi @nlharris We are currently addressing the comments provided by @addiehl and will keep you updated with the latest developments on the ontology. |
Title
Physiologically based pharmacokinetic modelling ontology
Short Description
Ontology aligned for PBPK modelling in life science domain
Description
The Physiologically-Based Pharmacokinetics (PBPK) ontology is a comprehensive framework designed to systematically capture and represent the intricate relationships and behaviors of pharmacokinetic processes within living organisms. At its core, the ontology encompasses a rich array of classes spanning physiological parameters, types of PBPK, biological compartments, and mathematical models that collectively contribute to the understanding of drug disposition and behavior in the body.the PBPK ontology serves as a unifying resource for researchers, clinicians, pharmacologists, and drug developers alike.By providing a structured vocabulary and semantic framework, it facilitates communication, data integration, and knowledge sharing across diverse research endeavors, thereby fostering collaboration and advancing scientific inquiry in pharmacokinetics and related disciplines.
Identifier Space
PBPKO
License
CC-BY 4.0
Domain
simulation
Source Code Repository
https://github.com/Crispae/pbpko
Homepage
https://crispae.github.io/pbpko/
Issue Tracker
https://github.com/Crispae/pbpko/issues
Contribution Guidelines
https://github.com/Crispae/pbpko/blob/main/docs/contributing.md
Ontology Download Link
https://github.com/Crispae/pbpko/blob/main/pbpko.owl
Contact Name
saurav kumar
Contact Email
[email protected]
Contact GitHub Username
Crispae
Contact ORCID Identifier
0000-0003-0593-2598
Formats
Dependencies
No response
Related
No response
Usages
No response
Intended Use Cases and/or Related Projects
PBPKO ontology will serve as a foundational resource for annotating and contextualizing Physiologically-Based Pharmacokinetics (PBPK) models within the domains of drug research and chemical risk assessment. PBPK model is a type of system biology model, hence direct integration of ontology with SBML allow automated annotation of model, if follow the standard approach.PBPK models is actively being develeoped in European project PARC.
Data Sources
PBPK expert community
Literature
Additional comments or remarks
As the PBPKO ontology is in the development phase, it benefits from continuous input and refinement by semantics.Requesting an Ontology ID space accelerates the process of integrating the ontology into models developed within the PARC project.
OBO Foundry Pre-registration Checklist
dc:license
annotation, serialised in RDF/XML.The text was updated successfully, but these errors were encountered: