Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeSitter causes hard freeze #518

Open
1 task done
TheSunCat opened this issue Jan 1, 2025 · 7 comments
Open
1 task done

TreeSitter causes hard freeze #518

TheSunCat opened this issue Jan 1, 2025 · 7 comments
Labels
bug Something isn't working

Comments

@TheSunCat
Copy link
Contributor

⚠️ Please verify that this bug has NOT been reported before.

  • I checked all existing issues and didn't find a similar issue

Description

Deleting a word in a C++ source file entirely freezes Neovim, requiring its process to be killed. My configuration: https://git.allpurposem.at/mat/Computer/src/branch/main/hm/modules/vim

This is likely due to tree-sitter/tree-sitter#3930, which is fixed by NixOS/nixpkgs#368952 .
Can anything be done from the nvf side in the meantime?

👟 Reproduction steps

This file repros it for me:

class test{
    Node* pNode{ nullptr };
};

Deleting pNode in any way causes a freeze.

👀 Expected behavior

Not freezing

😓 Actual Behavior

Freezing

💻 Metadata

  • system: "x86_64-linux" - host os: Linux 6.6.66, NixOS, 25.05 (Warbler), 25.05.20241219.d70bd19 - multi-user?: yes - sandbox: yes - version: nix-env (Lix, like Nix) 2.91.1 System type: x86_64-linux Additional system types: i686-linux, x86_64-v1-linux, x86_64-v2-linux, x86_64-v3-linux, x86_64-v4-linux Features: gc, signed-caches System configuration file: /etc/nix/nix.conf User configuration files: /home/mat/.config/nix/nix.conf:/nix/store/5igmh42rmaqj8wjr0zc28cqh9ch6rjjz-stylix-kde-config/nix/nix.conf:/etc/xdg/nix/nix.conf:/home/mat/.local/share/flatpak/exports/etc/xdg/nix/nix.conf:/var/lib/flatpak/exports/etc/xdg/nix/nix.conf:/home/mat/.nix-profile/etc/xdg/nix/nix.conf:/nix/profile/etc/xdg/nix/nix.conf:/home/mat/.local/state/nix/profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/mat/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf Store directory: /nix/store State directory: /nix/var/nix Data directory: /nix/store/873hdnqclw6c5kqax9mmw57a72rn4c3h-lix-2.91.1/share - channels(root): "nixos" - nixpkgs: /nix/store/8fwsiv0hd7nw1brkvka0jf1frk3m7qkr-source

📝 Relevant log output

N/A
@TheSunCat TheSunCat added the bug Something isn't working label Jan 1, 2025
@horriblename
Copy link
Collaborator

we'll wait for NixOS/nixpkgs#368952 to get into unstable then bump our inputs

@frolvanya
Copy link

we'll wait for NixOS/nixpkgs#368952 to get into unstable then bump our inputs

Do you know how much time it usually takes for a new package to be included into unstable branch?

@NotAShelf
Copy link
Owner

NotAShelf commented Jan 2, 2025

Usually PRs take 3-5 days to propagate into nixpkgs-unstable, which nvf follows.

PR status tracker here

@traxys
Copy link

traxys commented Jan 6, 2025

This PR targeted staging, which may take a lot longer (on the order of a month)

@frolvanya
Copy link

This PR targeted staging, which may take a lot longer (on the order of a month)

I decided to install nvim binary from releases page, this fixed an issue for now, so you can try this approach as well. I'll switch back to nix version once it will be fixed

@NotAShelf
Copy link
Owner

We were discussing alternatives for the TS issue, but the best option for now might be to roll back nvf's flake input to before the tree-sitter regression was caused, most likely before the latest Neovim version bump.

I will look into a more streamlined alternstive for managing TS and friends if this becomes a reoccurring theme.

@khaneliman
Copy link

Tree-sitter bump finally got merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants