Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Improvements tracker #6

Closed
13 tasks done
NikolaLohinski opened this issue Feb 28, 2023 · 0 comments
Closed
13 tasks done

📝 Improvements tracker #6

NikolaLohinski opened this issue Feb 28, 2023 · 0 comments
Assignees

Comments

@NikolaLohinski
Copy link
Owner

NikolaLohinski commented Feb 28, 2023

🚀 Features

See NikolaLohinski/gonja#3 for gonja related features

Click me to see finished work
  • fromyaml, toyaml filters
    (done in v1.11.1)

  • dir, basename would be good too
    (done in v1.11.1)

  • fromtoml, totoml filters
    (done in v1.13.0)

  • An file filter to load the content of a file into a variable, similarly to the include statement
    (done in v1.12.0)

  • Document gonja builtin statements, filters and globals in the provider docs
    (done in v1.12.0)

  • Move all filters to gonja itself (since it's now a fully maintained fork)
    (done in v1.12.0)

  • Add the ability to specify the working directory when dealing with inlined templates
    (done in v1.16.0 )

  • Move to the terraform plugin framework
    (Done in v2.0.0)

🐛 Bug fixes

Click me to see finished work
  • The split filter is buggy: "test_foo" | split("_") | last is not behaving as expected
    (done in v1.11.1)

  • Native gonja filter length is broken for objects
    (done in v1.12.0)

  • Native gonja filters such as select or selectattr are broken when it comes to the type they are returning and need to be fixed in gonja itself.

    Details

    For example:

    {{- [{"a": 1}, {"a": 2}] | selectattr("a", "==", 1) | first -}}
    

    does not work.

    (done in v1.12.0)

  • There's a bug most likely in gonja itself when it comes to indent trimmers.

    Details
    # [% if data.nope is defined -%]
    [% endif %]
    Should not be commented
    

    Renders as:

    # Should not be commented
    

    Instead of:

    # 
    Should not be commented
    

    when the variable is undefined

    (done in v1.12.0)

  • Comments don't seem to handle correctly whitespace control using -
    (done in v1.13.0)

@NikolaLohinski NikolaLohinski self-assigned this Feb 28, 2023
@NikolaLohinski NikolaLohinski changed the title Improve filters Improvements tracker Mar 15, 2023
@NikolaLohinski NikolaLohinski changed the title Improvements tracker 📋 Improvements tracker Mar 16, 2023
@NikolaLohinski NikolaLohinski changed the title 📋 Improvements tracker 📝 Improvements tracker Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant