Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter Manual Mods Install #2481

Open
LukeNexusMods opened this issue Jan 15, 2025 · 4 comments
Open

Smarter Manual Mods Install #2481

LukeNexusMods opened this issue Jan 15, 2025 · 4 comments
Labels
Epic: Collections This is related to NexusMods Collections.

Comments

@LukeNexusMods
Copy link
Collaborator

LukeNexusMods commented Jan 15, 2025

As a user
I want the app to make a best guess or recommendation for mods that would normally trigger the manual installer
So that I don't have to choose myself

Currently users can get a lot of popups during collection install triggering the manual installer. Ideally we should try to minimise this so it does not overwhelm the user. If we are able to identify where the mod should go the app should make ever effort to install it there.

@LukeNexusMods LukeNexusMods added the Epic: Collections This is related to NexusMods Collections. label Jan 15, 2025
@Pickysaurus
Copy link
Contributor

You should probably provide the context here. Which game? Which mods are triggering the advanced installer? Do we know why?

@halgari
Copy link
Collaborator

halgari commented Jan 15, 2025

I'm not sure I understand the "uses CPU threads" part of this. I don't think we actively tie up a CPU thread for the manual installer. At least if we do, that's probably a bug.

@LukeNexusMods
Copy link
Collaborator Author

Now... I may have misunderstood this but let me try to explain.

Florian said that if the number of mods triggering the manual installer matched the number of threads on your CPU then if you cancel it would not start looking at another mod to download and it would just stop. That is what I understood from "We install mods in parallel, the degree of parallelism is dependent on the amount of cores your system has. With 4 core, we'd install 4 mods at once. However, if those 4 mods are all using the advanced installer, then all installers are waiting for user input".

Best way to see this is to download and install this collection:
https://next.nexusmods.com/stardewvalley/collections/g3i395

If you cancel all the manual installers that pop up the install all process just stops.

@erri120
Copy link
Member

erri120 commented Jan 16, 2025

Probably duplicate of #2463.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Collections This is related to NexusMods Collections.
Projects
Status: No status
Development

No branches or pull requests

4 participants