-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MAX_UNIQUE_COUNT functionality #2678
Open
lbschanno
wants to merge
5
commits into
integration
Choose a base branch
from
feature/maxUniqueCount
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foster33
reviewed
Jan 6, 2025
Comment on lines
46
to
51
/** | ||
* A factory for SortedMapFileHandlers | ||
* | ||
* | ||
* | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra lines
Suggested change
/** | |
* A factory for SortedMapFileHandlers | |
* | |
* | |
* | |
*/ | |
/** | |
* A factory for SortedMapFileHandlers | |
*/ |
Add the ability to specify a max count on results from the unique operation such that only the unique results that occurred up to the specified max count are returned. This max count can be specified either via the function MAX_UNIQUE_COUNT or via the query parameter max.unique.count. Fixes #2635
lbschanno
force-pushed
the
feature/maxUniqueCount
branch
from
January 15, 2025 18:48
cf3852b
to
32496f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify a max count on results from the unique
operation such that only the unique results that occurred up to the
specified max count are returned.
This max count can be specified either via the function
MAX_UNIQUE_COUNT or via the query parameter max.unique.count.
Fixes #2635
NOTE: This work is based off existing work in PR #2570 and should only be merged after that PR.