Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CorrDiff bugfixes #756

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CorrDiff bugfixes #756

wants to merge 3 commits into from
+69 −35

Conversation

pzharrington
Copy link
Collaborator

Modulus Pull Request

Description

Fixes several bugs in the CorDiff example:

  • Handling of lead time label in the non-lead-time-aware case
  • GEFS-HRRR datapipe issue with channel index length
  • Hard-coding of stats.json to be a local file in GEFS-HRRR case

This incorporates the fixes in #718 as well as additional ones needed to make it work in the ResLoss

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@pzharrington pzharrington self-assigned this Jan 11, 2025
@pzharrington
Copy link
Collaborator Author

/blossom-ci

@pzharrington pzharrington changed the title CorDiff bugfixes CorrDiff bugfixes Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pzharrington pzharrington

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pzharrington @LostnEkko