Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StormCast training code improvements #738

Merged
merged 26 commits into from
Dec 16, 2024

Conversation

pzharrington
Copy link
Collaborator

@pzharrington pzharrington commented Dec 13, 2024

Modulus Pull Request

Description

Refactors the StormCast training recipe to be more in-line with Modulus examples and conventions. Notable changes:

  • Use a hydra-based config management system instead of YParams
  • Use Modulus neural networks (SongUNet, EDMPrecond) and add a regression U-Net wrapper for StormCast (StormCastUNet)
  • Use Modulus EDM loss and sampling routines
  • Use Modulus utilities for checkpointing and logging

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is
    up to date with these changes.

Dependencies

nvssh nssswitch user account and others added 26 commits November 12, 2024 23:37
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
Signed-off-by: Peter Harrington <[email protected]>
@pzharrington
Copy link
Collaborator Author

/blossom-ci

1 similar comment
@mnabian
Copy link
Collaborator

mnabian commented Dec 13, 2024

/blossom-ci

@mnabian
Copy link
Collaborator

mnabian commented Dec 14, 2024

Hey @pzharrington , I mostly looked at the changes to the sampler, preconditioner UNet, and metrics to make sure changes are backward compatible and are not breaking other codes. I also briefly looked at the isolated changes for the stormcast recipe and everything look good to me. Approving

@mnabian mnabian self-requested a review December 14, 2024 00:39
@pzharrington pzharrington merged commit c6dab48 into NVIDIA:main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants