Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀[FEA]: Add optional dev dependency to install packages needed for development #124

Closed
Tracked by #122
akshaysubr opened this issue Aug 9, 2023 · 1 comment
Closed
Tracked by #122

🚀[FEA]: Add optional dev dependency to install packages needed for development #124

akshaysubr opened this issue Aug 9, 2023 · 1 comment
Labels
? - Needs Triage Need team to review and classify enhancement New feature or request

Comments

@akshaysubr
Copy link
Collaborator

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

Currently, there isn't any easy way to figure out what packages are needed for a development setup. Eg: black, pre-commit, coverage, interrogate, etc. need to be installed to be able to run local checks but this isn't easy to figure out.

The best solution would be to create an optional dependency in the pyproject.toml for a dev setup so you can install the package and dev dependencies while developing using

pip install -e .[dev]

Describe any alternatives you have considered

Can document these dependencies in the contribution guide, but it isn't as seamless to use and actually install those packages.
@akshaysubr akshaysubr added enhancement New feature or request ? - Needs Triage Need team to review and classify labels Aug 9, 2023
@akshaysubr akshaysubr mentioned this issue Aug 9, 2023
Closed
@ktangsali
Copy link
Collaborator

This was added in this PR: #150. Closing.

ktangsali added a commit that referenced this issue Nov 3, 2023
@ktangsali
Ahmed body checkpointing fixes (#124)
efc497f 
* fix the directory name

* update model loading code

* minor cleanup

* black formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akshaysubr @ktangsali