From 8f0c6759f1cd1e159e61e60060a9f366531efb72 Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Mon, 9 Dec 2024 14:19:46 -0500 Subject: [PATCH 1/3] turn off jb eval --- 3dfgat.yaml.j2 | 5 +++++ 3dvar.yaml.j2 | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/3dfgat.yaml.j2 b/3dfgat.yaml.j2 index 40f6afd..41ba64f 100644 --- a/3dfgat.yaml.j2 +++ b/3dfgat.yaml.j2 @@ -5,6 +5,8 @@ cost function: cost type: 3D-FGAT + jb evaluation: false + time window: begin: '{{window_begin}}' length: '{{window_length}}' @@ -118,3 +120,6 @@ test: float absolute tolerance: {{test_float_absolute_tolerance | default(0.0, true) }} integer tolerance: {{test_integer_tolerance | default(0, true) }} {% endif %} + +# Turn off the final J eval +final j evaluation: false \ No newline at end of file diff --git a/3dvar.yaml.j2 b/3dvar.yaml.j2 index a96483b..8b2c59c 100644 --- a/3dvar.yaml.j2 +++ b/3dvar.yaml.j2 @@ -5,6 +5,8 @@ cost function: cost type: 3D-Var + jb evaluation: false + time window: begin: '{{window_begin}}' length: '{{window_length}}' @@ -112,3 +114,6 @@ test: float absolute tolerance: {{test_float_absolute_tolerance | default(0.0, true) }} integer tolerance: {{test_integer_tolerance | default(0, true) }} {% endif %} + +# Turn off the final J eval +final j evaluation: false \ No newline at end of file From e5a3d00b26bb9d779636fea88244c01f2e33b6a8 Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Mon, 9 Dec 2024 14:41:04 -0500 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Dan Holdaway <27729500+danholdaway@users.noreply.github.com> --- 3dfgat.yaml.j2 | 4 ++-- 3dvar.yaml.j2 | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/3dfgat.yaml.j2 b/3dfgat.yaml.j2 index 41ba64f..3e6a792 100644 --- a/3dfgat.yaml.j2 +++ b/3dfgat.yaml.j2 @@ -5,7 +5,7 @@ cost function: cost type: 3D-FGAT - jb evaluation: false + jb evaluation: {{ jb_evaluation | default(true) }} time window: begin: '{{window_begin}}' @@ -122,4 +122,4 @@ test: {% endif %} # Turn off the final J eval -final j evaluation: false \ No newline at end of file +final j evaluation: {{ final_j_evaluation | default(true) }} \ No newline at end of file diff --git a/3dvar.yaml.j2 b/3dvar.yaml.j2 index 8b2c59c..13b7363 100644 --- a/3dvar.yaml.j2 +++ b/3dvar.yaml.j2 @@ -5,7 +5,7 @@ cost function: cost type: 3D-Var - jb evaluation: false + jb evaluation: {{ jb_evaluation | default(true) }} time window: begin: '{{window_begin}}' @@ -116,4 +116,4 @@ test: {% endif %} # Turn off the final J eval -final j evaluation: false \ No newline at end of file +final j evaluation: {{ final_j_evaluation | default(true) }} \ No newline at end of file From 86e85f5ea4334f92b9efa579501d394c10154f2c Mon Sep 17 00:00:00 2001 From: Guillaume Vernieres Date: Mon, 9 Dec 2024 15:33:35 -0500 Subject: [PATCH 3/3] defaulting to no jb eval --- 3dfgat.yaml.j2 | 4 ++-- 3dvar.yaml.j2 | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/3dfgat.yaml.j2 b/3dfgat.yaml.j2 index 3e6a792..662c94a 100644 --- a/3dfgat.yaml.j2 +++ b/3dfgat.yaml.j2 @@ -5,7 +5,7 @@ cost function: cost type: 3D-FGAT - jb evaluation: {{ jb_evaluation | default(true) }} + jb evaluation: {{ jb_evaluation | default(false) }} time window: begin: '{{window_begin}}' @@ -122,4 +122,4 @@ test: {% endif %} # Turn off the final J eval -final j evaluation: {{ final_j_evaluation | default(true) }} \ No newline at end of file +final j evaluation: {{ final_j_evaluation | default(false) }} diff --git a/3dvar.yaml.j2 b/3dvar.yaml.j2 index 13b7363..d07ad3e 100644 --- a/3dvar.yaml.j2 +++ b/3dvar.yaml.j2 @@ -5,7 +5,7 @@ cost function: cost type: 3D-Var - jb evaluation: {{ jb_evaluation | default(true) }} + jb evaluation: {{ jb_evaluation | default(false) }} time window: begin: '{{window_begin}}' @@ -116,4 +116,4 @@ test: {% endif %} # Turn off the final J eval -final j evaluation: {{ final_j_evaluation | default(true) }} \ No newline at end of file +final j evaluation: {{ final_j_evaluation | default(false) }}