Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added openLibrary API #1437

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Added openLibrary API #1437

wants to merge 2 commits into from

Conversation

Adriano-7
Copy link
Member

Closes #[1436]

Added a second API openLibrary to the book fetcher.

Screenshot 2 Screenshot 1

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@Adriano-7 Adriano-7 linked an issue Jan 6, 2025 that may be closed by this pull request
Add a second books API #1436
Open
thePeras
thePeras approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The design of everyday things", a book in my list to read some day!

packages/uni_app/lib/controller/fetchers/book_fetcher.dart Outdated Show resolved Hide resolved
packages/uni_app/lib/controller/fetchers/book_fetcher.dart Outdated Show resolved Hide resolved
@Adriano-7 Adriano-7 self-assigned this Jan 6, 2025
@thePeras thePeras requested review from DGoiana, vitormpp and a team January 6, 2025 23:09
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 12%. Comparing base (b784754) to head (232c3a9).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff           @@
##           develop   #1437   +/-   ##
=======================================
- Coverage       12%     12%   -0%     
=======================================
  Files          265     265           
  Lines         7382    7397   +15     
=======================================
  Hits           819     819           
- Misses        6563    6578   +15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePeras thePeras thePeras approved these changes

@DGoiana DGoiana Awaiting requested review from DGoiana

@vitormpp vitormpp Awaiting requested review from vitormpp

At least 2 approving reviews are required to merge this pull request.

Assignees

@Adriano-7 Adriano-7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a second books API
2 participants
@Adriano-7 @thePeras