Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Elasticsearch restarts always rolling #349

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

widhalmt
Copy link
Member

@widhalmt widhalmt commented Oct 24, 2024

This PR will do the following:

  • move tasks for rolling start and stop into separate files
  • include the new files in the rolling upgrade tasks file
  • replace the simple "Restart Elasticsearch handler" with a new one that includes a file which itself includes the new task files

The idea is to make every single restart of Elasticsearch a rolling one.

Status:

  • Review the split up task lists and search for potential problems. Especially with when clauses. (For mow it's just moved code
  • Re-implement the systemctl daemom reload that went missing when replacing the restart task
  • Run real life tests

fixes #343

The idea to use include files that can be reused comes from @ivareri

@widhalmt widhalmt added the bug Something isn't working label Oct 24, 2024
@widhalmt widhalmt added this to the 0.1.0 milestone Oct 24, 2024
@widhalmt widhalmt self-assigned this Oct 24, 2024
@widhalmt widhalmt marked this pull request as draft October 24, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Make Elasticsearch service restart after config change more graceful
1 participant